CARVIEW |
Select Language
HTTP/2 200
date: Tue, 29 Jul 2025 12:43:31 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=387.889289,conversation_content-fragment;desc="conversation_content fragment";dur=527.855032,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=317.499462,nginx;desc="NGINX";dur=0.629071,glb;desc="GLB";dur=101.157135
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: 321f992
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=ftqhcZx6h7oOqbsACLRdiibRqcjg%2FDF%2BjYXRm0hF1H%2F0VdVn%2BGD5HUltMioV9yrI%2BYkNj9V4Ez1eymhn57Kxu4CEloaI0YXg4DOMdjmnVGDn%2FD6jbPnqJXQ8o6Wv4KK9aHrt%2BbNW96E7m%2FCsXZtnj8D0X%2FVr63C0lQ5wdTVUVynjKG%2BW6CkN%2BA3IStsodVihCmMmUUwMVrDV%2F5fzmdK76cQeXoXKwMzFwXsvVoH5j9TssUb2rP4xsn%2FMrGlAs4CLrXpVn7C0IVRyE29MgrC2kw%3D%3D--Lx7VXuGOfxkh3sx%2B--0e7BAp6esl8S0p3hCnkj8g%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.1160601517.1753793011; Path=/; Domain=github.com; Expires=Wed, 29 Jul 2026 12:43:31 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Wed, 29 Jul 2026 12:43:31 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: C2C2:B13D1:AEC650:D00FF9:6888C1F3
Fixes vdom issues with selecting insert before and rendering widgets after they have been destroyed by agubler · Pull Request #921 · dojo/widget-core · GitHub
Skip to content
Navigation Menu
{{ message }}
This repository was archived by the owner on Jul 30, 2018. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 38
Fixes vdom issues with selecting insert before and rendering widgets after they have been destroyed #921
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and skip widgets that have been queued but are destroyed
matt-gadd
approved these changes
May 1, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
Type: bug
The following has been addressed in the PR:
prettier
as per the readme code style guidelinesDescription:
vdom.ts
was processing widgets that had been detached by a previous render but had been invalidated themselves and therefore were already on the queue. To resolve this the call to "detach" widgets has been moved from request idle callback to be sync when processing renders. When a node it removed,onDetach
is called which removes all references such as an injector that would otherwise invalidate the detached widget and also removes the instance from theinstanceMap
so that it will not get rendered again.Also when processing nodes from higher in the dnode tree, there was a possibility that an incorrect reference (to the old node) could be used as the render process was traversing down the tree of the parent stored at the point of time it was rendered. If the lower component had rendered itself since the reference the node had in it's tree would be outdated. This changes
update
children to always look for a node from theinstanceMap
as that will always be the latest version of the widget and used this for processing removal.