CARVIEW |
Select Language
HTTP/2 200
date: Tue, 29 Jul 2025 12:43:13 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=339.781385,conversation_content-fragment;desc="conversation_content fragment";dur=552.778083,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=254.930022,nginx;desc="NGINX";dur=0.672816,glb;desc="GLB";dur=106.564724
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: 321f992
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=XouggcxsqElPOIDKmY56p6oyoVwuq3VvrzbX3ynzifoF3KpQA3emd2WgPBR8Z3EZeMO6AWdjCR83%2B15oVW4A7Mx%2Br4ezSHdq9ETDq1RSNuR29lvxXdoX4pzIF061g541uA6wvgkhNkhPx2SgO%2BiBwXvMi4c8iL%2B3EsdCVeuUp7c1M%2FaOJEyntjIGWEc9UFZw2EBJtgA%2Bq%2B8OgizOi0rnMd%2B7i3%2FmzYZP3pO5rl%2FuO8hCzJBM6OlaNztZugccWGd%2B0kwbv6gXUvwiNaUto1prlg%3D%3D--4zpq%2BYjDLRkzO5ym--m8vWIpkfJBWHL2irLIwIUA%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.524461339.1753792992; Path=/; Domain=github.com; Expires=Wed, 29 Jul 2026 12:43:12 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Wed, 29 Jul 2026 12:43:12 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: E390:22A039:AFC61E:D10F4A:6888C1E0
Move logic in custom element initialization by maier49 Β· Pull Request #744 Β· dojo/widget-core Β· GitHub
Skip to content
Navigation Menu
{{ message }}
This repository was archived by the owner on Jul 30, 2018. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 38
Move logic in custom element initialization #744
Merged
maier49
merged 5 commits into
dojo:master
from
maier49:531-add-children-to-custom-element
Nov 7, 2017
Merged
Move logic in custom element initialization #744
maier49
merged 5 commits into
dojo:master
from
maier49:531-add-children-to-custom-element
Nov 7, 2017
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kitsonk
approved these changes
Nov 6, 2017
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, but as requested @matt-gadd should review as well.
Looks like the custom element functional tests are failing on CI. |
matt-gadd
approved these changes
Nov 7, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You canβt perform that action at this time.
Type: feature
The following has been addressed in the PR:
Description:
If I'm understanding the code correctly, the widget won't render until it's attached to the projector. That happens here, in the callback that gets called when the custom element is attached to the DOM. So until that point we don't need to worry about a
MutationObserver
, because we can just capture the state of the element when it's attached and set the appropriate children at that time. This has the added benefit of letting things likereplaceChild
andinsertBefore
work as expected, without a lot of additional logic.If we want to be able to add children after the element is attached then we will probably need to track the elements we've seen and use a
MutationObserver
to detect new children and create widgets for them. That should probably be a separate PR though.Resolves #531