CARVIEW |
Select Language
HTTP/2 200
date: Mon, 28 Jul 2025 19:23:44 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=484.864875,conversation_content-fragment;desc="conversation_content fragment";dur=673.09122,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=376.960089,nginx;desc="NGINX";dur=1.385248,glb;desc="GLB";dur=100.541164
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: a2eb102
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=DEw3XUUQ8NobGLOvhrg2D5Y2sQYAQqw6j%2FA81fxthFILYAtt9fOLRnbaG1idBFQ4OMfhl5a9fW9owzabdW2V%2F%2FU6JhZDT%2F%2Byi2ZGsfghioDVpO2%2FLUGMawls4GHSzbL9%2Fb1oG04U0%2Fyz4lRCbr4jKy%2BemEHT3IXpnoC9uYTHGhiZcEghI6U4L40uZtAIm5Rs0bweJe7E7E%2BtSAgXMU7uXlsWwO%2FZ5yi3ZmYwFB0MjfV%2FyKSqfjvcw2wvVjwLlRA0YY8TK2Auv6YhLp14Rp0WPQ%3D%3D--k33RKzZN3LJ5PGkM--oLsV4Ws8CwZgKg5fWdCp0Q%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.329293421.1753730623; Path=/; Domain=github.com; Expires=Tue, 28 Jul 2026 19:23:43 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Tue, 28 Jul 2026 19:23:43 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: C1E2:22A039:1C7A1:2547F:6887CE3F
Support deferred properties by matt-gadd · Pull Request #736 · dojo/widget-core · GitHub
Skip to content
Navigation Menu
{{ message }}
This repository was archived by the owner on Jul 30, 2018. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agubler
approved these changes
Nov 1, 2017
Does |
@schontz inserted will always be true once the node is inserted into the dom (ie after the first render). |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
Type: feature
The following has been addressed in the PR:
Description:
v()
now supports a function as the second parameter (rather than justVirtualDomProperties
). If a callback is passed, the callback will be called on render as per usual, and then again on the nextrequestAnimationFrame
. This allows you to for example measure and apply changes to a property without having to trigger a full re-render, or change a style property to trigger a css transition.Example usage:
There are a few caveats which will likely be resolved in future:
in lieu of a bonafide scheduler, there is nothing fancy here - it will simply queue a deferred property callback to the next
rAF
even if a main render is scheduled for the nextrAF
. In the future it will be more desirable to remove deferred property callbacks from the queue if they are going to be updated as part of a main render anyway.there will currently be an issue with using
this.meta
in a deferred property callback on render due to us scheduling nodes to be added to the node handler (which meta uses for dom node existing) on arIC
rather than arAF
. the node handler also clears out nodes after each__render__
, which is problematic for anything deferred after it, so we will need a better way of handling dom nodes generally in the node handler.I will raise a PR with a readme update separately as their is an outstanding PR open.
Resolves #714