Widget class property `watch` decorator #75

agubler · 2018-08-21T13:52:50Z

Type: feature

The following has been addressed in the PR:

There is a related issue
All code has been formatted with prettier as per the readme code style guidelines
Unit or Functional tests are included in the PR

Description:

Adds a watch decorator that will call invalidate when the property is set automatically.

Resolves #74

mwistrand

Minor nit, but otherwise looks good.

mwistrand · 2018-08-21T19:25:05Z

src/widget-core/README.md

+
+It is common for widgets to maintain internal state, that directly affects the results of the render output or passed as properties to child widgets. The most common pattern is that an action (often user initiated via an event) occurs which updates the internal state leaving the user to manually call `this.invalidate()` to trigger a re-render.
+
+For class properties that always need to trigger a re-render when it's updated, a property decorator, `@watch` can be used, which implicitly calls `this.invalidate` each time the property is set.


"trigger a re-render when it's updated": "it's" => "they're"

agubler added 3 commits August 21, 2018 11:13

watch decorator

701d8c6

import order

d8984be

README

47041cf

agubler changed the title ~~Add watch decorator~~ Widget class property watch decorator Aug 21, 2018

agubler added enhancement New feature or request next Issue/Pull Request for the next major version labels Aug 21, 2018

mwistrand approved these changes Aug 21, 2018

View reviewed changes

README feedback

2f7d6eb

agubler merged commit 05e991a into dojo:master Aug 22, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Widget class property `watch` decorator #75

Widget class property `watch` decorator #75

Uh oh!

agubler commented Aug 21, 2018 •

edited

Loading

Uh oh!

mwistrand left a comment

Uh oh!

mwistrand Aug 21, 2018

Uh oh!

Uh oh!


		It is common for widgets to maintain internal state, that directly affects the results of the render output or passed as properties to child widgets. The most common pattern is that an action (often user initiated via an event) occurs which updates the internal state leaving the user to manually call `this.invalidate()` to trigger a re-render.

		For class properties that always need to trigger a re-render when it's updated, a property decorator, `@watch` can be used, which implicitly calls `this.invalidate` each time the property is set.

Widget class property watch decorator #75

Widget class property watch decorator #75

Uh oh!

Conversation

agubler commented Aug 21, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mwistrand left a comment

Choose a reason for hiding this comment

Uh oh!

mwistrand Aug 21, 2018

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Widget class property `watch` decorator #75

Widget class property `watch` decorator #75

agubler commented Aug 21, 2018 •

edited

Loading