CARVIEW |
Select Language
HTTP/2 200
date: Wed, 30 Jul 2025 01:20:21 GMT
content-type: text/html; charset=utf-8
cache-control: max-age=0, private, must-revalidate
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
link: ; rel=preload; as=fetch; crossorigin=use-credentials
referrer-policy: no-referrer-when-downgrade
server-timing: issue_layout-fragment;desc="issue_layout fragment";dur=162.224785,issue_conversation_content-fragment;desc="issue_conversation_content fragment";dur=467.443799,issue_conversation_sidebar-fragment;desc="issue_conversation_sidebar fragment";dur=43.167108,nginx;desc="NGINX";dur=0.396861,glb;desc="GLB";dur=107.326758
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With, Accept,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: 321f992
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=BFZXtS3lTdblRKxgOCHmJxhraz9sRj5zA%2FXVDjIUa%2FLWiH1Ki9fe%2FnjzovuFuJCuBE0WeoKKL0%2FCSuHDk22tJAeiEdnCnlZU4A9eEMFnFlIZkEpuzdkQiPI77FQou0%2BTx7Ep%2Fx20cuxTqIb%2FqLKfQjvqRKf9QcrKOuOXRmcOG%2BDSKFrMa9zO9pfxdjKo9DRT1zQUj%2FHDTw4F1dzgzXsHkhD3X4nyqApoI5ofspafGY8ck7cPl2KkEjP2ABZDJFfmdwMUum76WEZ1bmy2wW6q5g%3D%3D--TvMXvethtQEd3JAk--cNkhfI8Q%2FfXhHRD%2Fjp5JFg%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.2119211673.1753838420; Path=/; Domain=github.com; Expires=Thu, 30 Jul 2026 01:20:20 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Thu, 30 Jul 2026 01:20:20 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: C462:812B8:11023C5:1495B3F:68897354
Provide a widget that injects a function to enable consumers to change theme · Issue #256 · dojo/framework · GitHub
No one assignedNo typeNo projectsNo milestoneNone yetNo branches or pull requests
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 79
Closed
Labels
enhancementNew feature or requestNew feature or requestnextIssue/Pull Request for the next major versionIssue/Pull Request for the next major version
Description
Enhancement
Currently it takes a significant amount of boilerplate to inject a function that can be used to change the current theme into the widget tree:
// main.ts
import renderer from "@dojo/framework/widget-core/vdom";
import { w } from "@dojo/framework/widget-core/d";
import App from "./widgets/App";
import { Registry } from "@dojo/framework/widget-core/Registry";
import { registerThemeInjector, Theme } from "@dojo/framework/widget-core/mixins/Themed";
import myTheme from './my-theme';
const registry = new Registry();
const injector = registerThemeInjector(myTheme, registry);
registry.defineInjector("update-theme", invalidator => {
function themeSwitcher(theme: Theme) {
injector.set({ theme });
}
return () => themeSwitcher;
});
const r = renderer(() => w(App, {}));
r.mount({ registry });
// ThemeSwitcherContainer.ts
// Used in the application somewhere to inject the theme switcher function
import Container from "@dojo/framework/widget-core/Container";
import ThemeSwitcher from "./ThemeSwitcher";
export default Container(ThemeSwitcher, "update-theme", {
getProperties(injector) {
return {
themeSwitcher: injector
};
}
});
It would be helpful if Dojo could provide a customised widget that injects a function that can be to switch themes into an application widget tree.
The widget should be virtual and have no visual output, but provide an API to for the user to render widgets and nodes with access to the update theme function. This would remove the need for a user to register a new injector or create a custom container to get access to the update theme function.
Metadata
Metadata
Assignees
Labels
enhancementNew feature or requestNew feature or requestnextIssue/Pull Request for the next major versionIssue/Pull Request for the next major version
Type
Projects
Milestone
Relationships
Development
Issue actions
You can’t perform that action at this time.