| CARVIEW |
Select Language
HTTP/2 200
date: Wed, 30 Jul 2025 01:19:47 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=307.393756,conversation_content-fragment;desc="conversation_content fragment";dur=942.27663,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=260.995097,nginx;desc="NGINX";dur=0.944468,glb;desc="GLB";dur=107.229427
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: 321f992
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=CNkbgY9GzPl9%2FQYc5qjUs7cbMR1dkKCOVkMzFWetHqs5Ln9L5cJM%2BNL%2BRF8rAr9%2B4i4fhwzjwHeSc6RHk292S9PV3Yr9R5QJ3uuCgNnJkULbwWqn2NNUzNgQUBYrRGh0UHYeElyZ0OfApwuLiXYZBHPiIVWdPslyVNk1M9bobOBQvjnm0DYWYp3Y5c0uj9cGod9P1iytLYL7PPzVB7V4Kjz7C3BNoo0VSi8mFtf64vt25SKBjkZhmTtuaoGAXLow%2FERSkRgz4Qqfn%2BSJV%2Blseg%3D%3D--s7UZV3X7o2pafizl--69gN2BMq8CIqr6pfVr6qzA%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.543605579.1753838386; Path=/; Domain=github.com; Expires=Thu, 30 Jul 2026 01:19:46 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Thu, 30 Jul 2026 01:19:46 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: 8356:373199:15A716:20769B:68897332
Add external loader plugin from webpack-contrib by mwistrand · Pull Request #31 · dojo/cli-build-app · GitHub
mwistrand
force-pushed
the
7-external-loader-plugin
branch
2 times, most recently
from
August 14, 2018 16:45
mwistrand
force-pushed
the
7-external-loader-plugin
branch
from
August 14, 2018 16:50
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 29
Add external loader plugin from webpack-contrib #31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #31 +/- ##
==========================================
- Coverage 59.17% 57.42% -1.75%
==========================================
Files 8 8
Lines 436 451 +15
Branches 93 101 +8
==========================================
+ Hits 258 259 +1
- Misses 178 192 +14
Continue to review full report at Codecov.
|
|
Documentation such as https://github.com/dojo/cli-build-webpack#interop-with-external-libraries should probably be updated in this PR when this change is landed. |
|
@maier49 @mwistrand There are two open PRs for supporting externals, this and #98 - Do you think we could consolidate them down into a single PR and make any requested changes in the reviews? |
|
Closing in favor of #98. |
|
Matt Wistrand seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. |
mwistrand
force-pushed
the
7-external-loader-plugin
branch
2 times, most recently
from
41b56bb to
1e3dd3d
Compare
- Add ExternalLoaderPlugin from webpack-contrib - TEMP: Add webpack-contrib deps to package.json and test-app/package.json - Update unix fixtures - Reset package-lock.json so it does not throw errors on install
mwistrand
force-pushed
the
7-external-loader-plugin
branch
from
1e3dd3d to
2ac549d
Compare
- Remove unneeded node modules - Add `externals` to `test-app/.dojorc-pwa`
matt-gadd
reviewed
Aug 15, 2018
package.json
Outdated
| @@ -112,6 +112,7 @@ | |||
| "express": "4.16.2", | |||
| "extract-text-webpack-plugin": "3.0.2", | |||
| "file-loader": "1.1.5", | |||
| "html-webpack-include-assets-plugin": "1.0.2", | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this used?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nope. I thought I deleted that.
matt-gadd
approved these changes
Aug 16, 2018
|
I have now verified the most recent changes with a local sandbox app on both Windows and macOS. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
None yet
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
Resolves #7. Requires a patch release of
webpack-contrib, which this PR makes up for by directly adding dependencies topackage.jsonandtest-app/package.json(these will be removed prior to merging).Adds the
ExternalLoaderPluginfrom@dojo/webpack-contrib, allowing external dependencies that cannot be loaded with webpack to be injected from outside the build. There is a nearly identical implementation in@dojo/cli-build-webpack, but with two notable differences:amd {request}toexternalscallback in v3Â webpack/webpack#6302)dojo/_base/langcan be excluded directly without needing to exclude all ofdojoordojo/_base.