refactor: remove registerEvents function (#10877)

sdanialraza · web-flow · commit 2c21de68f3bd · 2025-05-11T12:21:13.000Z
* refactor: remove `registerEvents` function

* refactor: use try-catch

* fix: missing `await`
diff --git a/packages/create-discord-bot/template/Deno/src/events/interactionCreate.ts b/packages/create-discord-bot/template/Deno/src/events/interactionCreate.ts
@@ -0,0 +1,20 @@
+import { Events } from 'npm:discord.js@^14.19.3';
+import type { Event } from './index.ts';
+import { loadCommands } from '../util/loaders.ts';
+
+const commands = await loadCommands(new URL('../commands/', import.meta.url));
+
+export default {
+	name: Events.InteractionCreate,
+	async execute(interaction) {
+		if (interaction.isCommand()) {
+			const command = commands.get(interaction.commandName);
+
+			if (!command) {
+				throw new Error(`Command '${interaction.commandName}' not found.`);
+			}
+
+			await command.execute(interaction);
+		}
+	},
+} satisfies Event<Events.InteractionCreate>;
diff --git a/packages/create-discord-bot/template/Deno/src/index.ts b/packages/create-discord-bot/template/Deno/src/index.ts
@@ -1,18 +1,24 @@
 import 'https://deno.land/std@0.223.0/dotenv/load.ts';
 import { URL } from 'node:url';
 import { Client, GatewayIntentBits } from 'npm:discord.js@^14.19.3';
-import { loadCommands, loadEvents } from './util/loaders.ts';
-import { registerEvents } from './util/registerEvents.ts';
+import { loadEvents } from './util/loaders.ts';
 
 // Initialize the client
 const client = new Client({ intents: [GatewayIntentBits.Guilds] });
 
 // Load the events and commands
 const events = await loadEvents(new URL('events/', import.meta.url));
-const commands = await loadCommands(new URL('commands/', import.meta.url));
 
 // Register the event handlers
-registerEvents(commands, events, client);
+for (const event of events) {
+	client[event.once ? 'once' : 'on'](event.name, async (...args) => {
+		try {
+			await event.execute(...args);
+		} catch (error) {
+			console.error(`Error executing event ${String(event.name)}:`, error);
+		}
+	});
+}
 
 // Login to the client
 void client.login(Deno.env.get('DISCORD_TOKEN'));
diff --git a/packages/create-discord-bot/template/Deno/src/util/registerEvents.ts b/packages/create-discord-bot/template/Deno/src/util/registerEvents.ts
diff --git a/packages/create-discord-bot/template/JavaScript/src/events/index.js b/packages/create-discord-bot/template/JavaScript/src/events/index.js
@@ -23,7 +23,7 @@ export const schema = z.object({
 /**
  * Defines the predicate to check if an object is a valid Event type.
  *
- * @type {import('../util/loaders').StructurePredicate<Event>}
+ * @type {import('../util/loaders.js').StructurePredicate<Event>}
  * @returns {structure is Event}
  */
 export const predicate = (structure) => schema.safeParse(structure).success;
diff --git a/packages/create-discord-bot/template/JavaScript/src/events/interactionCreate.js b/packages/create-discord-bot/template/JavaScript/src/events/interactionCreate.js
@@ -0,0 +1,20 @@
+import { Events } from 'discord.js';
+import { loadCommands } from '../util/loaders.js';
+
+const commands = await loadCommands(new URL('../commands/', import.meta.url));
+
+/** @type {import('../events/index.js').Event<Events.InteractionCreate>} */
+export default {
+	name: Events.InteractionCreate,
+	async execute(interaction) {
+		if (interaction.isCommand()) {
+			const command = commands.get(interaction.commandName);
+
+			if (!command) {
+				throw new Error(`Command '${interaction.commandName}' not found.`);
+			}
+
+			await command.execute(interaction);
+		}
+	},
+};
diff --git a/packages/create-discord-bot/template/JavaScript/src/index.js b/packages/create-discord-bot/template/JavaScript/src/index.js
@@ -1,18 +1,24 @@
 import process from 'node:process';
 import { URL } from 'node:url';
 import { Client, GatewayIntentBits } from 'discord.js';
-import { loadCommands, loadEvents } from './util/loaders.js';
-import { registerEvents } from './util/registerEvents.js';
+import { loadEvents } from './util/loaders.js';
 
 // Initialize the client
 const client = new Client({ intents: [GatewayIntentBits.Guilds] });
 
 // Load the events and commands
 const events = await loadEvents(new URL('events/', import.meta.url));
-const commands = await loadCommands(new URL('commands/', import.meta.url));
 
 // Register the event handlers
-registerEvents(commands, events, client);
+for (const event of events) {
+	client[event.once ? 'once' : 'on'](event.name, async (...args) => {
+		try {
+			await event.execute(...args);
+		} catch (error) {
+			console.error(`Error executing event ${String(event.name)}:`, error);
+		}
+	});
+}
 
 // Login to the client
 void client.login(process.env.DISCORD_TOKEN);
diff --git a/packages/create-discord-bot/template/JavaScript/src/util/registerEvents.js b/packages/create-discord-bot/template/JavaScript/src/util/registerEvents.js
diff --git a/packages/create-discord-bot/template/TypeScript/src/events/interactionCreate.ts b/packages/create-discord-bot/template/TypeScript/src/events/interactionCreate.ts
@@ -0,0 +1,21 @@
+import { URL } from 'node:url';
+import { Events } from 'discord.js';
+import { loadCommands } from '../util/loaders.[REPLACE_IMPORT_EXT]';
+import type { Event } from './index.[REPLACE_IMPORT_EXT]';
+
+const commands = await loadCommands(new URL('../commands/', import.meta.url));
+
+export default {
+	name: Events.InteractionCreate,
+	async execute(interaction) {
+		if (interaction.isCommand()) {
+			const command = commands.get(interaction.commandName);
+
+			if (!command) {
+				throw new Error(`Command '${interaction.commandName}' not found.`);
+			}
+
+			await command.execute(interaction);
+		}
+	},
+} satisfies Event<Events.InteractionCreate>;
diff --git a/packages/create-discord-bot/template/TypeScript/src/index.ts b/packages/create-discord-bot/template/TypeScript/src/index.ts
@@ -1,18 +1,24 @@
 import process from 'node:process';
 import { URL } from 'node:url';
 import { Client, GatewayIntentBits } from 'discord.js';
-import { loadCommands, loadEvents } from './util/loaders.[REPLACE_IMPORT_EXT]';
-import { registerEvents } from './util/registerEvents.[REPLACE_IMPORT_EXT]';
+import { loadEvents } from './util/loaders.[REPLACE_IMPORT_EXT]';
 
 // Initialize the client
 const client = new Client({ intents: [GatewayIntentBits.Guilds] });
 
 // Load the events and commands
 const events = await loadEvents(new URL('events/', import.meta.url));
-const commands = await loadCommands(new URL('commands/', import.meta.url));
 
 // Register the event handlers
-registerEvents(commands, events, client);
+for (const event of events) {
+	client[event.once ? 'once' : 'on'](event.name, async (...args) => {
+		try {
+			await event.execute(...args);
+		} catch (error) {
+			console.error(`Error executing event ${String(event.name)}:`, error);
+		}
+	});
+}
 
 // Login to the client
 void client.login(process.env.DISCORD_TOKEN);
diff --git a/packages/create-discord-bot/template/TypeScript/src/util/registerEvents.ts b/packages/create-discord-bot/template/TypeScript/src/util/registerEvents.ts

Original file line number	Diff line number	Diff line change
`@@ -23,7 +23,7 @@ export const schema = z.object({`
`23`	`23`	`/**`
`24`	`24`	`* Defines the predicate to check if an object is a valid Event type.`
`25`	`25`	`*`
`26`		`- * @type {import('../util/loaders').StructurePredicate<Event>}`
	`26`	`+ * @type {import('../util/loaders.js').StructurePredicate<Event>}`
`27`	`27`	`* @returns {structure is Event}`
`28`	`28`	`*/`
`29`	`29`	`export const predicate = (structure) => schema.safeParse(structure).success;`