CARVIEW |
Select Language
HTTP/2 200
date: Wed, 23 Jul 2025 00:22:03 GMT
content-type: text/html; charset=utf-8
cache-control: max-age=0, private, must-revalidate
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
link: ; rel=preload; as=fetch; crossorigin=use-credentials
referrer-policy: no-referrer-when-downgrade
server-timing: issue_layout-fragment;desc="issue_layout fragment";dur=220.997508,issue_conversation_content-fragment;desc="issue_conversation_content fragment";dur=540.140645,issue_conversation_sidebar-fragment;desc="issue_conversation_sidebar fragment";dur=45.344521,nginx;desc="NGINX";dur=1.108202,glb;desc="GLB";dur=102.121228
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With, Accept,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: fd8fbbc
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=dVsGb1fQTe4HLr1cnuUNbvUjn87zt8hWMAqpBS8FCIcQN7axKXTS51pBoO3JLMAIbbL3291PVPYL0Pl1Y80eHesduw7jcgwrQoL34RNxVabQO9ebgspiyf0BsGKbJ1qiEKxeyEFKH8M%2FgwAXLpOaUnQhiOjc6CI0qv2Oq45H4i5qokubXSqvTjpX9PuIwy1mdZmobiMQhvxRXXx7yCZ7kX2fGWhTK4LxX5bEh4gnHT7Vs3jAdcUSLuPuILTT5jwsr8JpJJnjrDuCRvFjWaGhGg%3D%3D--GDz4RbAY9tuUb26B--qBcq6nWw6KkKsI9ehxKRVw%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.2056881522.1753230122; Path=/; Domain=github.com; Expires=Thu, 23 Jul 2026 00:22:02 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Thu, 23 Jul 2026 00:22:02 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: EC46:351DD4:1EFC23:2B2D2F:68802B2A
On the new workflow and pull request standards · Issue #300 · devicons/devicon · GitHub
No one assignedNo typeNo projectsNo milestoneNone yetNo branches or pull requests
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
Closed
Labels
discussionCommunity discussions about changes/features/..Community discussions about changes/features/..
Description
Hey everyone,
So @amacado and I discussed with other on how the branches and build icons will work from now on. Below is what we talked about and the decisions that we arrived at. If anyone has any further inputs on how the build script should work, feel free to leave a comment below this post.
Our Discussions:
-
Creating a new
develop
branch.- Currently, the build script can’t push local master to remote master. The bot doesn’t have permission to do it and we don’t want the bot to have that permission. This is because we want to review the PR before we merge anything in to the
master
branch. - Our Solution:
- Let the bot not trigger on push/pr into specific branch. Instead, trigger the build when someone adds a specific label to their PR.
- Only people with write permission can add labels to the PRs. This would not trigger the build script for non-valid branches and remove unnecessary run-time + notifications.
- Instead of publishing the result back into the contributor's branch as we are doing, the bot would create a new branch (
foo
) that has the changes and open a PR forfoo
into this branch.- This is done so that the contributor can see their new icons in the
index.html
and fix any issues if needed. They will then decide whether to accept the changes into the branches.
- This is done so that the contributor can see their new icons in the
- Let the bot not trigger on push/pr into specific branch. Instead, trigger the build when someone adds a specific label to their PR.
- Currently, the build script can’t push local master to remote master. The bot doesn’t have permission to do it and we don’t want the bot to have that permission. This is because we want to review the PR before we merge anything in to the
-
What the new workflow will look like (the
CONTRIBUTING.md
will be updated with this content):- Contributor (Charlie) read
CONTRIBUTING.md
- Charlie will fork our repo and create a new branch from “develop”. They would name it
feature/{{id-of-issue}}-{{description}}
according to our standards, ex.feature/104-angularjs
. - They would add their icons to our repo and their icon info to the
devicon.json
. They must ensure their fonts are ok (visually correct, in the correct folder etc…) before continuing.- Side note: At least the plain or line version of the icon is required (since those are required for the icon font)
- Charlie then commit their changes and create pull requests from their branch into the
devicon/develop
branch.- They must create a separated pull request for each icon (no matter how many variations)
- They must also include the name of the icon in the pull request f.e. "new icon: html5 (original, plain, line)"
- Optional: Add a image of the new icon(s) to the description of the pull request
- Optional: Reference the issues regarding the new icon
- Collaborators/maintainers (say Mike) would review their branches (assign the reviewer so other collaborators don’t redo your work)
- Mike will add the label
bot: build
if the PR is valid, else he'd comment and let the contributor know what’s wrong. - Once the label
bot: build
is added, the bot will trigger the build action - The build result will be published in a new branch and a pull request is auto created to merge this build branch (
build/feature/{{id-of-issue}}-{{description}}
) back into the contributor’s branch - Charlie will reviews the change. If they are fine with it, they will accept the changes and Mike will merge it into
develop
- Contributor (Charlie) read
-
Release schedules:
- We will release the develop branch in master branch when we think it’s a good time for release (ex. in case we don’t have any icons in a particular frame of time) or when it’s a hot fix (ex. broken icons, etc…)
-
Future plans:
- Update the GitHub Pages.
- Eventually,
master
branch will be used to host our (GitHub pages)[https://github.com/migrate gh-pages to master branch #289]. - Publish npm package.
- Create build scripts for the above tasks.
-
Label convention for GitHub actions -> have a
bot:
prefix:bot: build
bot: publish
bot: release
-
Possible new yml format for our GitHub Actions file:
on:
label:
type: [created,edited]
jobs:
job01:
// Check for the github.event.label.name, make sure the conditional works. See if we need to use a “IN” operation instead of “==”
if: github.event.label.name == 'bot: build'
- The Selenium Issue:
- This might be from icomoon site’s anti-bot network policy
- We can’t do anything for now and the script still runs => let's ignore it for now.
ezSaldana
Metadata
Metadata
Assignees
Labels
discussionCommunity discussions about changes/features/..Community discussions about changes/features/..
Type
Projects
Milestone
Relationships
Development
Issue actions
You can’t perform that action at this time.