CARVIEW |
Select Language
HTTP/2 200
date: Fri, 10 Oct 2025 05:29:10 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com github.githubassets.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com wss://alive-staging.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com marketplace-screenshots.githubusercontent.com/ copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=352.187312,conversation_content-fragment;desc="conversation_content fragment";dur=333.026443,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=300.629046,nginx;desc="NGINX";dur=0.693625,glb;desc="GLB";dur=144.163518
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: 266d7a9
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=sw0KG8Vg8Z5P6CIhiwJ4VkzD8m0QRYetNysVtK6PxuDk%2FQp2d0iumOx%2F%2F9wON5g8phEEtUs07qJ06O3lKCLRGqMgXjX3Tyr6olxLUjJoEHcYOVdje3EgB9DMuCjYot4y65NGFpg3obwaRh1DMKGWSnpGEiNoJhk8xO5TIHRNVMxZhAX5qwTkG86T9GkNWQWHRVFxRGMdR4k7YXFL5xLN0mi7OkDAWwEn3njB5jXGiyIZNwVHbrYPEgnYyQV9vQdvot%2BBxy1SE%2F%2Bsv%2BF9lvrMHw%3D%3D--7GBvR4MphaSs2W2I--cghAudrkAqvnlT68YqIlQw%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.668990658.1760074150; Path=/; Domain=github.com; Expires=Sat, 10 Oct 2026 05:29:10 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Sat, 10 Oct 2026 05:29:10 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: 89B0:379ADD:135B4A2:1779DDF:68E899A6
feat: Display banner for rows updated since last visit by simonw · Pull Request #6 · datasette/datasette-chronicle · GitHub
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 1
feat: Display banner for rows updated since last visit #6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
simonw
wants to merge
1
commit into
main
Choose a base branch
from
feature/show-updated-rows-banner
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I've implemented a mechanism to notify you about table row updates that occurred since your last visit to a specific table page. Key changes: - I introduced `extra_js_urls`, `extra_head_html`, and `extra_body_script` hooks in `datasette_chronicle/__init__.py`. - `extra_body_script` injects the current maximum version ID of the chronicle table, along with database and table names, into a JavaScript variable on the table page. - `extra_js_urls` links a new static JavaScript file. - `extra_head_html` injects CSS for styling the notification banner. - I added `datasette_chronicle/static/datasette_chronicle.js`, which: - Reads the max version from the injected variable. - Stores and retrieves the last seen version and timestamp for the table from `localStorage`. - If the current max version is newer, it fetches the count of updated rows using the existing `?_since=` API. - Displays a banner at the top of the page showing the number of new rows and the time since your last visit. - Updates `localStorage` with the new max version and timestamp. - I added comprehensive tests in `tests/test_chronicle.py`: - Unit tests for the new Python hooks. - Playwright end-to-end tests to verify the JavaScript behavior, including `localStorage` interactions and banner display under various scenarios (first visit, no changes, new changes). This feature enhances your awareness of data changes within Datasette tables that have chronicle enabled.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
Here's what https://jules.google.com/ produced when I pasted in the full markdown of #3, exported using https://tools.simonwillison.net/github-issue-to-markdown
I have not yet reviewed this code.
It said: