tools/trim: only consider defaults when we're not ignoring the conjunct
If a conjunct has been marked to be ignored, then we should not consider
it even if it is a default for a disjunction.
This change does not prevent trimming of code due to defaults: there's a
specific defaults.txtar (which is unchanged) which shows the existence
of defaults can still lead to trimming.
Fixes: #3995
Change-Id: I0a693f2f14caf744f4d04ba39293b3871acdd71d
Signed-off-by: Matthew Sackman <matthew@cue.works>
Reviewed-on: https://review.gerrithub.io/c/cue-lang/cue/+/1219302
TryBot-Result: CUEcueckoo <cueckoo@cuelang.org>
Unity-Result: CUE porcuepine <cue.porcuepine@gmail.com>
Reviewed-by: Daniel Martí <mvdan@mvdan.cc>

internal/ci: allow gerritHubHostname to be overridden
This will allow us to experiment with an alternative GerritHub host in
other repos that depend on this internal/ci CUE module.
Signed-off-by: Paul Jolly <paul@myitcv.io>
Change-Id: I692f4416b98b4743941199f6068d9106a7443c5b
Reviewed-on: https://review.gerrithub.io/c/cue-lang/cue/+/1218940
TryBot-Result: CUEcueckoo <cueckoo@cuelang.org>
Reviewed-by: Daniel Martí <mvdan@mvdan.cc>
Unity-Result: CUE porcuepine <cue.porcuepine@gmail.com>

internal/core/adt: filter notifications
Unconditionally adding a node for notifications
is costly. "Popular" schema can easily get into
the thousands of notifications. As long as all
conjuncts are known, there is really no need to
register the schema for notification.
To detect this is straightforward: if all ancestors
have been processed, and the parent of
a schema has computed all tasks that can
compute field conjuncts, all conjuncts are known.
We also lower the trigger to include diffs
for notifications to 10 Notifications. This
adds a couple of files.
Issue #3334
Issue #2850
Signed-off-by: Marcel van Lohuizen <mpvl@gmail.com>
Change-Id: Iee6f4342295d87ebfd5b8ac1a0a3e5f5f60f0d1b
Reviewed-on: https://review.gerrithub.io/c/cue-lang/cue/+/1218273
Unity-Result: CUE porcuepine <cue.porcuepine@gmail.com>
Reviewed-by: Daniel Martí <mvdan@mvdan.cc>
TryBot-Result: CUEcueckoo <cueckoo@cuelang.org>

all: simplify three iterator uses with range-over-func
These were written before we could rely on range-over-func.
Signed-off-by: Daniel Martí <mvdan@mvdan.cc>
Change-Id: Id37ddfca6cec5d8fbc7cb612a8ce025f809e7db1
Reviewed-on: https://review.gerrithub.io/c/cue-lang/cue/+/1217429
TryBot-Result: CUEcueckoo <cueckoo@cuelang.org>
Reviewed-by: Roger Peppe <rogpeppe@gmail.com>
Unity-Result: CUE porcuepine <cue.porcuepine@gmail.com>

internal/cueversion: bump for v0.13.2
Signed-off-by: Daniel Martí <mvdan@mvdan.cc>
Change-Id: I22e3fe65ef1ebda1279ad40a72326ec4c9d5cfba
Reviewed-on: https://review.gerrithub.io/c/cue-lang/cue/+/1217400
TryBot-Result: CUEcueckoo <cueckoo@cuelang.org>
Reviewed-by: Roger Peppe <rogpeppe@gmail.com>

internal/ci: bump Go version for v0.13.1
Signed-off-by: Daniel Martí <mvdan@mvdan.cc>
Change-Id: Ice9663d2c2771a42446414d18a30b2830d49a532
Reviewed-on: https://review.gerrithub.io/c/cue-lang/cue/+/1216731
Reviewed-by: Roger Peppe <rogpeppe@gmail.com>
TryBot-Result: CUEcueckoo <cueckoo@cuelang.org>

internal/mod/modfiledata: factor out of mod/modfile
We'd like the `build.Instance` returned by `load.Instances` to be
able to contain the module file current to that instance, but currently
that's not possible because the `cue` package depends on `cue/build`
and the `modfile` package depends on the `cue` package so there
would be an illegal cyclic dependency from doing that.
To work around that, we factor out the data-only `modfile.File` type
into its own `modfiledata` package, so it's possible to depend on the
module file data without having a dependency on the evaluator itself.
In the process, we avoid storing `actualSchemaVersion` in the
struct because it's actually only used as part of `Format`
and not anywhere else; this avoids the need for a public accessor
in the `File` type.
Signed-off-by: Roger Peppe <rogpeppe@gmail.com>
Change-Id: Idf08de5f146a9f57b6fd5c9f11f2c56648ea6ade
Reviewed-on: https://review.gerrithub.io/c/cue-lang/cue/+/1215651
TryBot-Result: CUEcueckoo <cueckoo@cuelang.org>
Reviewed-by: Daniel Martí <mvdan@mvdan.cc>
Reviewed-by: Matthew Sackman <matthew@cue.works>

internal/ci: bump the pinned Go version for releases
Ahead of v0.13.0.
Signed-off-by: Daniel Martí <mvdan@mvdan.cc>
Change-Id: Icd839c0bf91338d93bc2bd3329b66e5e8319c458
Reviewed-on: https://review.gerrithub.io/c/cue-lang/cue/+/1215667
TryBot-Result: CUEcueckoo <cueckoo@cuelang.org>
Reviewed-by: Paul Jolly <paul@myitcv.io>

cmd/cue: add CUE_EXPERIMENT=cmdreferencepkg
When enabled, `cue cmd` tasks must be defined by referencing a task
from one of the tool packages, and trying to define a task directly
by only defining `kind` or `$id` will not work.
The experiment is disabled by default for v0.13 as it is very late
in the release cycle and too many users would be broken
with too little notice. We plan to flip the default for v0.14.
Signed-off-by: Daniel Martí <mvdan@mvdan.cc>
Change-Id: I246acf526910b1486ab9c41b96abe56dd1980eab
Reviewed-on: https://review.gerrithub.io/c/cue-lang/cue/+/1214987
Reviewed-by: Marcel van Lohuizen <mpvl@gmail.com>
Reviewed-by: Paul Jolly <paul@myitcv.io>
TryBot-Result: CUEcueckoo <cueckoo@cuelang.org>

internal/ci: bump Go and goreleaser for the next alpha release
As usual, none of the goreleaser deprecations affect us.
Signed-off-by: Daniel Martí <mvdan@mvdan.cc>
Change-Id: I25acd939ed4946b8d3bb706778d6e7d58fae6743
Reviewed-on: https://review.gerrithub.io/c/cue-lang/cue/+/1214051
Reviewed-by: Roger Peppe <rogpeppe@gmail.com>
TryBot-Result: CUEcueckoo <cueckoo@cuelang.org>
Unity-Result: CUE porcuepine <cue.porcuepine@gmail.com>