| CARVIEW |
Select Language
HTTP/2 200
date: Fri, 25 Jul 2025 18:12:59 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=330.190746,conversation_content-fragment;desc="conversation_content fragment";dur=627.030149,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=266.343034,nginx;desc="NGINX";dur=1.316261,glb;desc="GLB";dur=100.742224
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: a2eb102
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=FJaHgQXfFcIIuneZgfEU0V01su2bXZyntRw6dT0gj6IE1zrUw8kD072eJShyJEFPmQFb%2Fe8wkEBEMN7bxbU6sB1IGGgJE7wEnLwT8vtlUGzHNtl7EhRDpBxaE5YSbjX8F4rkxLyrxO0kUH%2BB7F2GBmS1ffIxcUK3RAGE6HXhGMwksExoCfZ6ejpDxTV2e%2F1YXTVIYPiZC6QTsvYExkKoBIVlcl24Ip0XnDvMtcpHoFchi4DJXeh2cTkTpeNYAzb%2BLMQhGzOWePBorq9gIdKEFA%3D%3D--jG5s3C9HdOZGAT05--1X5GTZ%2BVbMm721b%2BRmr2xw%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.608270140.1753467178; Path=/; Domain=github.com; Expires=Sat, 25 Jul 2026 18:12:58 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Sat, 25 Jul 2026 18:12:58 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: A57C:2B31B4:B2081:DA4EF:6883C92A
Fix server shutdown logic by austinvazquez · Pull Request #130 · containerd/ttrpc · GitHub
austinvazquez
force-pushed
the
fix-server-shutdown
branch
10 times, most recently
from
February 25, 2023 00:31
austinvazquez
force-pushed
the
fix-server-shutdown
branch
3 times, most recently
from
February 25, 2023 00:59
austinvazquez
force-pushed
the
fix-server-shutdown
branch
from
February 27, 2023 16:26
austinvazquez
force-pushed
the
fix-server-shutdown
branch
from
February 27, 2023 16:45
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 84
Fix server shutdown logic #130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
austinvazquez
force-pushed
the
fix-server-shutdown
branch
10 times, most recently
from
fc0e242 to
9925d37
Compare
|
austinvazquez
force-pushed
the
fix-server-shutdown
branch
3 times, most recently
from
6006966 to
e5894c3
Compare
austinvazquez
force-pushed
the
fix-server-shutdown
branch
from
e5894c3 to
dcee46b
Compare
Simplify close idle connections logic in server shutdown to be more intuitive. Modify add connection logic to check if server has been shutdown before adding any new connections. Modify test to make all calls before server shutdown. Signed-off-by: Austin Vazquez <macedonv@amazon.com>
austinvazquez
force-pushed
the
fix-server-shutdown
branch
from
dcee46b to
19445fd
Compare
This was referenced Feb 27, 2023
kzys
approved these changes
Mar 7, 2023
cpuguy83
approved these changes
Mar 7, 2023
dmcgowan
approved these changes
Mar 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
None yet
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
Fixes #129
Simplify close idle connections logic in server shutdown to be more
intuitive. Modify add connection logic to check if server has been
shutdown before adding any new connections. Modify test to make all
calls before server shutdown.
Signed-off-by: Austin Vazquez macedonv@amazon.com