| CARVIEW |
Select Language
HTTP/2 200
date: Fri, 25 Jul 2025 19:43:48 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=300.254535,conversation_content-fragment;desc="conversation_content fragment";dur=687.268359,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=238.768791,nginx;desc="NGINX";dur=0.932265,glb;desc="GLB";dur=100.705224
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: a2eb102
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=ospKsGh0Fx%2FRvC9c2057DKSbPmc4KOiBi2%2Fqwpb9Wo%2B8fDbTWGdeLpqDgaETRVszlA%2BMlmBozihtnwOf8Ud%2BXllUvgXPehSuQTpkim3xD9OUE6A3qd0OIutu5PrrH3P%2B9xIxqY%2FI4H7UarGw%2BWPAGa43eMoZR6sKi3K6IAO12tIrZOeWFrMStKfRs%2BSQoYwwDxhgt2GnwMgFDaXxKxYZjE5B5roKTOOF2zGJSFykb87CBsLBRV2btA1dVsQyDECnraC50uj%2FacBkskmSskJ9xQ%3D%3D--TtmJ0Lqv1J8A02MB--24EjD45XEHN%2BsERFIMeicA%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.1417679791.1753472628; Path=/; Domain=github.com; Expires=Sat, 25 Jul 2026 19:43:48 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Sat, 25 Jul 2026 19:43:48 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: 9776:32DF28:67CF9:88CA1:6883DE74
fixes: sort final adjusted mount slice. by klihub · Pull Request #29 · containerd/nri · GitHub
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 79
fixes: sort final adjusted mount slice. #29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Krisztian Litkey <krisztian.litkey@intel.com>
After adjusting mounts sort the final slice to make sure that any potential subdirectories are mounted only after their parents. Signed-off-by: Krisztian Litkey <krisztian.litkey@intel.com>
Codecov ReportBase: 63.39% // Head: 63.83% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #29 +/- ##
==========================================
+ Coverage 63.39% 63.83% +0.44%
==========================================
Files 9 9
Lines 1781 1800 +19
==========================================
+ Hits 1129 1149 +20
+ Misses 501 500 -1
Partials 151 151
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
fuweid
reviewed
Feb 24, 2023
| // with a minor tweak for stable sorting order (easier to test): | ||
| // | ||
| // https://github.com/moby/moby/blob/17.05.x/daemon/volumes.go#L26 | ||
| type orderedMounts []rspec.Mount |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It't not blocked issue. Just thinking that we can export it into utils pkg, instead of copy-parse.
Handle it in the follow-up.
fuweid
approved these changes
Feb 24, 2023
|
@klihub is it ok to create v0.3.0 tag after this merged? |
|
@fuweid Yes, let's tag it. I have no other PRs ATM in the pipeline. |
nice! I will create tag in two days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
None yet
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
If mounts get adjusted, sort the final mount slice to make sure that any potential subdirectories are mounted only after their parents. Otherwise a parent mount could shadow/mask the content of a previously mounted subdirectory.