| CARVIEW |
Select Language
HTTP/2 200
date: Fri, 25 Jul 2025 20:55:08 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=334.146337,conversation_content-fragment;desc="conversation_content fragment";dur=516.284655,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=221.100261,nginx;desc="NGINX";dur=1.149051,glb;desc="GLB";dur=100.744052
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: a2eb102
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=TIwRD9aOywpXJ3lyibqkS3RO49GFvQwWsqeUoG4oeyIWeHkw5JiTUwZHqttxPyVRcROPDYOqaaUtc1yUfU8tUfkLBZj0QVUKHLkgIvottFFU59swaexLNwU6Gs99JTLI24mhAHXLhfNibqRf6tlhEIWimqVz0VZJysDz88d4dL5Fo1u60fP8bkPHYc6BOnFmk6r6xJZEtWt462PfUBc7ukZJcw5O20Ubx4PEucFupRkRJlQ4%2BNa4NtXFeyw8XthQ2iYPsFw62CbfD1S5R9krZw%3D%3D--V1BxpjasHumkOzvi--5HFLa8G50YgyNhklolTvZw%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.1786646663.1753476907; Path=/; Domain=github.com; Expires=Sat, 25 Jul 2026 20:55:07 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Sat, 25 Jul 2026 20:55:07 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: 9F24:3F7FD6:C035B:1058CA:6883EF2B
Make plugin timeouts configurable, adjust default socket path. by klihub · Pull Request #26 · containerd/nri · GitHub
klihub
force-pushed
the
better-config
branch
from
February 16, 2023 07:14
klihub
force-pushed
the
better-config
branch
from
February 16, 2023 07:19
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 79
Make plugin timeouts configurable, adjust default socket path. #26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change default socket path to /var/run/nri/nri.sock. This should work better for plugins which are run as Kubernetes daemonsets. With the socket directory bind-mounted instead of the socket itself, plugins should be able to reconnect if the runtime is ever restarted. Additionally, create any missing NRI/socket directory with 0700 rights (rwx for owner only) instead of 0755. Signed-off-by: Krisztian Litkey <krisztian.litkey@intel.com>
fuweid
reviewed
Feb 16, 2023
klihub
force-pushed
the
better-config
branch
from
8b05e1c to
aac9507
Compare
Codecov ReportBase: 70.07% // Head: 69.92% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #26 +/- ##
==========================================
- Coverage 70.07% 69.92% -0.16%
==========================================
Files 7 7
Lines 1514 1533 +19
==========================================
+ Hits 1061 1072 +11
- Misses 323 331 +8
Partials 130 130
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Allow the default plugin timeouts to be overridden. This should allow us to give plugins more slack in slow/overloaded CI envs. Signed-off-by: Krisztian Litkey <krisztian.litkey@intel.com>
klihub
force-pushed
the
better-config
branch
from
aac9507 to
fbbce23
Compare
fuweid
approved these changes
Feb 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
None yet
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
Update defaults for plugin registration and request processing timeouts and make them configurable. This should help testing plugins with a complex startup/registration sequence in very slow CI environments where registration otherwise sometimes triggers a timeout.
Also adjust the default socket path to
/var/run/nri/nri.sockand create the parent directory for the socket with0700access rights instead of0755. Having an intermediate directory makes it easier for plugins that run as a K8s daemonset to survive a runtime restart an reconnect to the NRI socket.