| CARVIEW |
Select Language
HTTP/2 200
date: Fri, 25 Jul 2025 20:02:32 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=380.33114,conversation_content-fragment;desc="conversation_content fragment";dur=772.498796,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=251.471643,nginx;desc="NGINX";dur=1.103345,glb;desc="GLB";dur=101.273383
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: a2eb102
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=pdy2f%2BfGiXPbLpGar2zMi6ebuuw6S5FsSO0d6arrVdrKzoaFyq%2FhhWlKVdVUElSUQQ5coiwr3SuIJcET2YzA%2BpqqXWwOK8ovVAGlO4heRl%2F9snMvlEXwTJO3XMEizYetfCCKF11xO3Zw%2BVhx%2Bv0VwXcGVJugieV1raH8p80We9iV7g5n9az%2Bfst%2FWcVYhaJyiJGt%2FvtDXH2dV6y2IY6m3P5rFWoCWRwRPJTwLESiTNSmBCOifiL13wGo%2BNkfpuCb8Nw9rOqPI3%2FyaYuqfOf%2B1Q%3D%3D--KtOwVVz6t5yCFSIy--Wv4K%2BrqJJJ9Z08pMxCbY9g%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.475331381.1753473751; Path=/; Domain=github.com; Expires=Sat, 25 Jul 2026 20:02:31 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Sat, 25 Jul 2026 20:02:31 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: 94E0:30074E:80B64:AB31C:6883E2D7
Add Go 1.20 support by austinvazquez · Pull Request #111 · containerd/go-cni · GitHub
austinvazquez
force-pushed
the
add-go-1.20-support
branch
2 times, most recently
from
February 9, 2023 19:11
austinvazquez
force-pushed
the
add-go-1.20-support
branch
from
February 10, 2023 16:13
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 65
Add Go 1.20 support #111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
AkihiroSuda
merged 1 commit into
containerd:main
from
austinvazquez:add-go-1.20-support
Feb 11, 2023
Merged
Add Go 1.20 support #111
AkihiroSuda
merged 1 commit into
containerd:main
from
austinvazquez:add-go-1.20-support
Feb 11, 2023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
austinvazquez
commented
Feb 9, 2023
.github/workflows/ci.yml
Outdated
| @@ -44,7 +44,7 @@ jobs: | |||
|
|
|||
| strategy: | |||
| matrix: | |||
| go-version: [1.17.x] | |||
| go-version: [1.17.x, 1.18.x, 1.19.x, 1.20.x] | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Linting with each version of Go might be a little pedantic. Lmk your thoughts.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need to support 1.17 and 1.18
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, let's just keep it to the last 2 supported releases of Go
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good. Pushed an update with the changes.
austinvazquez
force-pushed
the
add-go-1.20-support
branch
2 times, most recently
from
b2ef584 to
0083665
Compare
Updates containerd/project-checks to v1.1.0 to run with Go 1.20. Updates golangci/golangci-lint to v1.51.1 for Go 1.20 support. Adds Go 1.20 to lint and test steps. Bumps minimum required version to Go 1.19 Signed-off-by: Austin Vazquez <macedonv@amazon.com>
austinvazquez
force-pushed
the
add-go-1.20-support
branch
from
0083665 to
4930cbf
Compare
estesp
approved these changes
Feb 10, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
AkihiroSuda
approved these changes
Feb 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
None yet
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
Updates containerd/project-checks to v1.1.0 to run with Go 1.20. Updates
golangci/golangci-lint to v1.51.1 for Go 1.20 support. Adds Go 1.20 to
lint and test steps. Bumps minimum required version to Go 1.19
Signed-off-by: Austin Vazquez macedonv@amazon.com