You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
estesp
merged 1 commit into
containerd:main
from
gabriel-samfira:force-downgrade-mingwJun 27, 2022
+8
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
There is currently an issue in the race detector in Go on Windows when
used with a newer version of GCC. The issue was first reported here:
golang/go#46099Fixes#7104
Signed-off-by: Gabriel Adrian Samfira <gsamfira@cloudbasesolutions.com>
The downgrade steps are pretty long lived.. Says it took 8m 30s on the ws2022 run neutral_face
The default Github runners are not that beefy, unfortunately. It takes a while to download+install+generate the shims. Will let them finish before sending the update with the comment to the Downgrade step.
The downgrade steps are pretty long lived.. Says it took 8m 30s on the ws2022 run 😐
I was worried about hitting the timeout but looks like we have it at 50m for Windows integration runs and at 33m we are on the last 2 steps, so at least that part should be fine (and this is on ws2022 which took 3.5 minutes longer for the downgrade than 2019)
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is currently an issue in the race detector in Go on Windows when
used with a newer version of GCC. The issue was first reported here:
golang/go#46099
Fixes #7104
Signed-off-by: Gabriel Adrian Samfira gsamfira@cloudbasesolutions.com