You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
Mostly because majority of the existing comments are using upper-case and the usage seemed similar to how we refer a proper noun.
Makes sense. My bias would be lower-case, but we don't have a style guide so this is fine too. (Since you're at Amazon: you can check around with the doc writers there but the AWS style guide generally prefers lower-case for object names.)
Your fixup commit is causing CI to fail since it does not have a proper DCO signature. Mind squashing the commits together and making sure you retain the Signed-off-by line so that the CI workflow can continue?
Makes sense. My bias would be lower-case, but we don't have a style guide so this is fine too. (Since you're at Amazon: you can check around with the doc writers there but the AWS style guide generally prefers lower-case for object names.)
Thanks for the review. I have not seen any such style guide myself, but I will look around. Perhaps it will have some good justification around the using lower case.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Swagat Bora sbora@amazon.com
snapshotter.go
comments to use uppercase in all places forthe Snapshotter