You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all
I was planning to call zstd(1) instead of using the pure Go implementation, but seems it wouldn't result any performance gain. Go is faster than I thought :)
% go test -bench BenchmarkDecompression
goos: linux
goarch: amd64
pkg: github.com/containerd/containerd/archive/compression
cpu: Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
BenchmarkDecompression/size=32MiB/gzip-96 1000000000 0.1552 ns/op
BenchmarkDecompression/size=32MiB/zstd-96 1000000000 0.08588 ns/op
BenchmarkDecompression/size=32MiB/gzipPureGo-96 1000000000 0.2111 ns/op
BenchmarkDecompression/size=32MiB/zstdPureGo-96 1000000000 0.08232 ns/op
BenchmarkDecompression/size=64MiB/gzip-96 1000000000 0.2945 ns/op
BenchmarkDecompression/size=64MiB/zstd-96 1000000000 0.1465 ns/op
BenchmarkDecompression/size=64MiB/gzipPureGo-96 1000000000 0.4157 ns/op
BenchmarkDecompression/size=64MiB/zstdPureGo-96 1000000000 0.1109 ns/op
BenchmarkDecompression/size=128MiB/gzip-96 1000000000 0.6552 ns/op
BenchmarkDecompression/size=128MiB/zstd-96 1000000000 0.3235 ns/op
BenchmarkDecompression/size=128MiB/gzipPureGo-96 1000000000 0.8044 ns/op
BenchmarkDecompression/size=128MiB/zstdPureGo-96 1000000000 0.2584 ns/op
BenchmarkDecompression/size=256MiB/gzip-96 1 1275289951 ns/op
BenchmarkDecompression/size=256MiB/zstd-96 1000000000 0.5624 ns/op
BenchmarkDecompression/size=256MiB/gzipPureGo-96 1 1656262363 ns/op
BenchmarkDecompression/size=256MiB/zstdPureGo-96 1000000000 0.5702 ns/op
PASS
ok github.com/containerd/containerd/archive/compression 160.223s
go test -bench BenchmarkDecompression 211.31s user 41.57s system 157% cpu 2:40.57 total
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The benchmarks were deleted in #2640 but we could use that to evaluate
zstd further.
Signed-off-by: Kazuyoshi Kato katokazu@amazon.com