CARVIEW |
Navigation Menu
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Bump Golang and MinGW versions in Windows setup script. #6888
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hi @aznashwan. Thanks for your PR. I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Currently doing a full CI run to validate the changes, will update the PR once I've confirmed it works. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
eeb2c10
to
6fc7509
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@@ -5,7 +5,7 @@ | |||
# lived test environment. | |||
Set-MpPreference -DisableRealtimeMonitoring:$true | |||
|
|||
$PACKAGES= @{ mingw = "10.2.0"; git = ""; golang = "1.18"; make = ""; nssm = "" } | |||
$PACKAGES= @{ mingw = "11.2.0"; git = ""; golang = "1.18.3"; make = ""; nssm = "" } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh! nice one; I definitely missed this one when grep'ing for the go version to update
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
You may need to rebase your branch to fix the Git issue. |
Signed-off-by: Nashwan Azhari <nazhari@cloudbasesolutions.com>
6fc7509
to
d25b4e6
Compare
After the switch to MinGW 11.2.0 in containerd#6888, the containerd client integration tests were crashing with an apparent memory allocation error as described in golang/go#46099. This patch reverts MinGW to 10.3.0 to bypass the issue. Signed-off-by: Nashwan Azhari <nazhari@cloudbasesolutions.com>
After the switch to MinGW 11.2.0 in containerd#6888, the containerd client integration tests were crashing with an apparent memory allocation error as described in golang/go#46099. This patch reverts MinGW to 10.3.0 to bypass the issue. Signed-off-by: Nashwan Azhari <nazhari@cloudbasesolutions.com>
Signed-off-by: Nashwan Azhari nazhari@cloudbasesolutions.com