| CARVIEW |
Navigation Menu
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
fix can't edit object by using ctr content edit command #6847
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hi @zhanghe9702. Thanks for your PR. I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Build succeeded.
|
zhanghe9702
force-pushed
the
pr/fix-content-edit
branch
from
1bb92e6 to
3b058d4
Compare
|
Build succeeded.
|
Please sign the commit using your real name rather than github username |
zhanghe9702
force-pushed
the
pr/fix-content-edit
branch
from
3b058d4 to
5e435f7
Compare
|
Build succeeded.
|
|
The vim/nvim works in different ways under different filesystem. If the temp file in tmpfs, the vim/nvim will open the original file and rewrite all the content. If it is in ext4, it will use other file to rename to override the original file so that the inode will be changed. |
zhanghe9702
force-pushed
the
pr/fix-content-edit
branch
from
5e435f7 to
2cb34ff
Compare
zhanghe9702
force-pushed
the
pr/fix-content-edit
branch
2 times, most recently
from
3a34358 to
ddcd694
Compare
hmm... rerun it again. |
|
:-), looks like race detector alloc memory failed in windows, is the same issue golang/go#46099? |
not sure why. I don't have windows so it is hard to debug. I will file a issue for that. |
|
@zhanghe9702 would you mind to rebase and repush it again? I rerun several times but it is unhappy... thanks 🙏 |
|
no problem! |
|
hmm... , i should already done rebase commit, this is git info |
You can try git commit --amend --no-edit |
zhanghe9702
force-pushed
the
pr/fix-content-edit
branch
from
ddcd694 to
faec0d3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
This problem is related to vim/nvim's writebackup mechanism. On non-tmpfs filesystem, vim first writes to a temporary file and then rename it. The practice of reopening the file is more general.
|
filed issue #7104 to track this flaky case. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The change is not related to CI failure. Re-run several times but still failed. :(
|
@zhanghe9702 would you mind to rebase? the CI has been fixed~ |
zhanghe9702
force-pushed
the
pr/fix-content-edit
branch
from
faec0d3 to
8b95c0b
Compare
|
done! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
zhanghe9702
force-pushed
the
pr/fix-content-edit
branch
3 times, most recently
from
d4bffff to
536c5e0
Compare
Signed-off-by: zhang he <zhanghe9702@163.com>
zhanghe9702
force-pushed
the
pr/fix-content-edit
branch
from
536c5e0 to
b8bb33b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix LGTM but I'd like if the commit message/pr description described why this fixes the issue as well
Signed-off-by: zhanghe9702 zhanghe9702@163.com
fix #6846