| CARVIEW |
Select Language
HTTP/2 200
date: Sat, 26 Jul 2025 10:32:58 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=376.890347,conversation_content-fragment;desc="conversation_content fragment";dur=1454.873404,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=328.585855,nginx;desc="NGINX";dur=1.080041,glb;desc="GLB";dur=902.737008
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: a2eb102
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=CwKdZoETlYPnC6Lp7nBFiDH8wLicPAuFGQiDQGZdgzUG0%2BRjmbWKupQQ9dgt5hOyirfFBB95AOfy%2Ftpsil6DcZ2x4LmZifmHIwz63uJoQGjB5daPaXbo42Lpp6llmWvCK9MTrxuAMCyhHkqI4XLAsuzdGReBVhi5eP11ZvdCBIAXMvmXMUuVPBkISVusiiQ3PNL%2B0KdvYtP7B%2FQv1MyjSaZYrIrxBJ2sgt2b%2BE94Zt46d1%2FXQFuHiXWzmJ76tlvMQQmBSh%2FOXnAbV7cQLjlLJg%3D%3D--l%2FrAGg8t1gU9U9dS--QHdrjjewjDJlaxB1TnO7cg%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.2107828281.1753525977; Path=/; Domain=github.com; Expires=Sun, 26 Jul 2026 10:32:57 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Sun, 26 Jul 2026 10:32:57 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: A25E:1A1F38:471B61:5D8FD2:6884AED8
Drop gotest.tools by mxpv · Pull Request #6762 · containerd/containerd · GitHub
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Drop gotest.tools #6762
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Drop gotest.tools #6762
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build succeeded.
|
samuelkarp
approved these changes
Apr 1, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I left suggestions where I think the use of Testify could be more idiomatic, but I don't think any of those should be blocking.
| defer unlock("testref") | ||
|
|
||
| err = tryLock("testref") | ||
| assert.ErrorContains(t, err, "ref testref locked for ") | ||
| require.NotNil(t, err) | ||
| assert.Contains(t, err.Error(), "ref testref locked for ") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
| assert.Contains(t, err.Error(), "ref testref locked for ") | |
| assert.ErrorContains(t, err, "ref testref locked for ") |
| "%d > %d", layer2Usage.Size, sizeBytes) | ||
| } | ||
|
|
||
| func TestMkfsExt4(t *testing.T) { | ||
| ctx := context.Background() | ||
| // We test the default setting which is lazy init is disabled | ||
| err := mkfs(ctx, "ext4", "nodiscard,lazy_itable_init=0,lazy_journal_init=0", "") | ||
| assert.ErrorContains(t, err, `mkfs.ext4 couldn't initialize ""`) | ||
| assert.Contains(t, err.Error(), `mkfs.ext4 couldn't initialize ""`) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
| assert.Contains(t, err.Error(), `mkfs.ext4 couldn't initialize ""`) | |
| assert.ErrorContains(t, err, `mkfs.ext4 couldn't initialize ""`) |
Comment on lines
+274
to
+277
| assert.NotNil(t, err) | ||
| if err != nil { | ||
| assert.Contains(t, err.Error(), "remove") | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this can be simplified
Suggested change
| assert.NotNil(t, err) | |
| if err != nil { | |
| assert.Contains(t, err.Error(), "remove") | |
| } | |
| assert.ErrorContains(t, err, "remove") |
|
I've addressed the majority of suggestions. |
Signed-off-by: Maksym Pavlenko <pavlenko.maksym@gmail.com>
Signed-off-by: Maksym Pavlenko <pavlenko.maksym@gmail.com>
samuelkarp
approved these changes
Apr 2, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks!
|
Build succeeded.
|
estesp
approved these changes
Apr 2, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
None yet
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
Currently we rely on two different helper libraries for testing:
gotest.tools/v3/assertgithub.com/stretchr/testify/assertBoth offer more or less same set of APIs, so there is no reason to keep both.
Looks like
testifygot better adoption accross containerd's codebase.So this PR migrates tests to
testifyand dropsgotest.tools/v3/assertdependency.