| CARVIEW |
Select Language
HTTP/2 200
date: Fri, 25 Jul 2025 18:10:21 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=283.403098,conversation_content-fragment;desc="conversation_content fragment";dur=736.256846,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=280.512124,nginx;desc="NGINX";dur=1.228242,glb;desc="GLB";dur=103.128192
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: a2eb102
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=pkpA%2BWwf0Wl0me0NdzHqtfXhu425F6lqYpbZyzljD8kQpuzqO25367kr6FwBaIDGb3i%2BJ7Rqoab9PfvOrj00XYdVHzlOXud15R8HKBiynv76hdig9MlSO7uB3z7RDlDzKxZDvXxrXFejB%2FXd%2BT%2FRNRWfL1DHFJNd6WAXSWDIJ2dYrgok1TJZ3WB7omHJIr%2BR6OsNGfbW01pM2sARwjWvyRRJ5p4owmlVtseXg0t2RMwZu95fhbwdx6MLKWZQZ0HQ%2B6C2WnA7XkeEgXWBLxqbcQ%3D%3D--nmY6qKyPZPs0oqeE--eDzanIa1jR1oQM02g92uZg%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.1576270830.1753467020; Path=/; Domain=github.com; Expires=Sat, 25 Jul 2026 18:10:20 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Sat, 25 Jul 2026 18:10:20 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: D4DC:89048:23C09:2CB1F:6883C88C
Adding multi-arch support for the configure.sh script by nobellium1997 · Pull Request #6751 · containerd/containerd · GitHub
nobellium1997
force-pushed
the
arm-support-gce-configure
branch
4 times, most recently
from
March 31, 2022 23:04
nobellium1997
force-pushed
the
arm-support-gce-configure
branch
from
April 1, 2022 19:09
nobellium1997
force-pushed
the
arm-support-gce-configure
branch
from
April 1, 2022 19:10
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Adding multi-arch support for the configure.sh script #6751
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
estesp
merged 1 commit into
containerd:main
from
nobellium1997:arm-support-gce-configure
Apr 1, 2022
Merged
Adding multi-arch support for the configure.sh script #6751
estesp
merged 1 commit into
containerd:main
from
nobellium1997:arm-support-gce-configure
Apr 1, 2022
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @nobellium1997. Thanks for your PR. I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
nobellium1997
force-pushed
the
arm-support-gce-configure
branch
4 times, most recently
from
a5a0166 to
f95260f
Compare
|
Build succeeded.
|
kzys
approved these changes
Apr 1, 2022
dmcgowan
reviewed
Apr 1, 2022
contrib/gce/configure.sh
Outdated
| @@ -126,8 +126,16 @@ else | |||
|
|
|||
| # TODO(random-liu): Put version into the metadata instead of | |||
| # deciding it in cloud init. This may cause issue to reboot test. | |||
| version=$(curl -f --ipv4 --retry 6 --retry-delay 3 --silent --show-error \ | |||
| https://storage.googleapis.com/${deploy_path}/latest) | |||
| if [ $(arch) == "aarch64" ]; then | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it better to use uname -m? arch isn't on all linux systems
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah good point. Fixed.
nobellium1997
force-pushed
the
arm-support-gce-configure
branch
from
f95260f to
94fd4b0
Compare
This script is used by various tests to install and configure containerd. However, right now it's hardcoded to only support x86 and not other architectures like arm. This change will now check the architecture of the machine the script is running on and will pull the correct artifacts accordingly from the correct artifact store (GCS vs Github). Signed-off-by: Nobel Barakat <nobelbarakat@google.com>
nobellium1997
force-pushed
the
arm-support-gce-configure
branch
from
94fd4b0 to
4bdac2b
Compare
|
Build succeeded.
|
dmcgowan
approved these changes
Apr 1, 2022
estesp
approved these changes
Apr 1, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
This script is used by various tests to install and configure
containerd. However, right now it's hardcoded to only support x86
and not other architectures like arm. This change will now check the
architecture of the machine the script is running on and will pull
the correct artifacts accordingly from the correct artifact store
(GCS vs Github).
Signed-off-by: Nobel Barakat nobelbarakat@google.com