| CARVIEW |
Select Language
HTTP/2 200
date: Fri, 25 Jul 2025 18:13:03 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=338.973973,conversation_content-fragment;desc="conversation_content fragment";dur=1739.329695,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=349.733858,nginx;desc="NGINX";dur=1.03671,glb;desc="GLB";dur=102.273599
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: a2eb102
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=yGnqX1LKjOstlnRt%2BKK7tc01llqJ3Q8sqCu57rx2tgUNx%2FrP7DipvOpHjZGfrh%2BIvypcbEM%2FFNilMeosBMegt1kNye8bom4t%2BRDZuQXAfH8Da6JjzTU03pV3SnZsS%2BVkQfiTA%2FkYh1Z3BtjP%2BTS3Ll7ynHKA%2FmYg7QhO2i%2B1O29uEGPO1zjxwyEAIsghg0cZuJFoCGjA1ROIeX%2FbPkC7h%2BydV6MfRlA6qUnSP2OlJGHtpm5rd9mf4E4K1U161yqCdjH8o%2Fjn8wZ4gQD%2FgkUDtw%3D%3D--DnO6ULH9cJ8f61Mo--niwLiv1jnJmnhtPQHG%2BfOg%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.1187819713.1753467181; Path=/; Domain=github.com; Expires=Sat, 25 Jul 2026 18:13:01 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Sat, 25 Jul 2026 18:13:01 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: A5A4:3AE478:AEB1B:D6FA6:6883C92D
Use typeurl.Any instead of github.com/gogo/protobuf/types.Any by kzys · Pull Request #6706 · containerd/containerd · GitHub
kzys
force-pushed
the
typeurl-upgrade
branch
4 times, most recently
from
March 22, 2022 02:03
kzys
force-pushed
the
typeurl-upgrade
branch
3 times, most recently
from
March 22, 2022 07:06
kzys
force-pushed
the
typeurl-upgrade
branch
2 times, most recently
from
March 22, 2022 13:43
kzys
force-pushed
the
typeurl-upgrade
branch
2 times, most recently
from
March 23, 2022 02:36
kzys
force-pushed
the
typeurl-upgrade
branch
3 times, most recently
from
March 23, 2022 17:55
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Use typeurl.Any instead of github.com/gogo/protobuf/types.Any #6706
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Skipping CI for Draft Pull Request. |
|
@mxpv @dmcgowan Regarding exported methods that take Any, like https://github.com/containerd/typeurl/blob/fc3423ac466f5ea0956f96572993fbac5afa3233/types.go#L146-L160, does it make sense to take Any as an interface? All we need is TypeURL and Value. gogo/protobuf and google.golang.org/protobuf can agree about the signature.
The Get prefix and casing (Url instead of URL) are less Go-idiomatic though. |
|
Build succeeded.
|
|
@kzys yeah, that is a good idea |
|
Much simpler containerd/typeurl#32 |
kzys
force-pushed
the
typeurl-upgrade
branch
4 times, most recently
from
db2b205 to
18212ad
Compare
|
Build succeeded.
|
|
Build succeeded.
|
|
Build succeeded.
|
|
Build succeeded.
|
|
Build succeeded.
|
kzys
force-pushed
the
typeurl-upgrade
branch
3 times, most recently
from
36512bc to
8a586e4
Compare
|
Build succeeded.
|
|
Build succeeded.
|
kzys
force-pushed
the
typeurl-upgrade
branch
2 times, most recently
from
c285162 to
cf17c36
Compare
kzys
commented
Mar 22, 2022
Comment on lines
47
to
50
| // typeurl.MarshalAny currently returns &types.Any, but it will | ||
| // return typeurl.Any soon. | ||
| pbany := &types.Any{ | ||
| TypeUrl: any.GetTypeUrl(), | ||
| Value: any.GetValue(), | ||
| } | ||
|
|
||
| for _, id := range imgcrypt.PayloadToolIDs { | ||
| c.ProcessorPayloads[id] = any | ||
| c.ProcessorPayloads[id] = pbany | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the local change I made. If that looks okay, I'm going to open a PR against imgcrypt.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense đź‘Ť
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Opened containerd/imgcrypt#72.
kzys
commented
Mar 22, 2022
| @@ -284,7 +285,7 @@ func (c *container) NewTask(ctx context.Context, ioCreate cio.Creator, opts ...N | |||
| if err != nil { | |||
| return nil, err | |||
| } | |||
| request.Options = any | |||
| request.Options = protobuf.FromAny(any) | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
request (CreateTaskRequest) is generated from a proto. So we have to call FromAny() here.
kzys
force-pushed
the
typeurl-upgrade
branch
2 times, most recently
from
3089cc6 to
c9a0904
Compare
|
Build succeeded.
|
kzys
force-pushed
the
typeurl-upgrade
branch
3 times, most recently
from
7cae71d to
231128c
Compare
|
Build succeeded.
|
|
Build succeeded.
|
|
Build succeeded.
|
|
Build succeeded.
|
|
Build succeeded.
|
|
Build succeeded.
|
|
This is finally ready for review! While there are still gogo/protobuf's Any here and there, I don't want to increase the size of this PR anymore. |
|
Build succeeded.
|
kzys
commented
Mar 24, 2022
|
Build succeeded.
|
|
Build succeeded.
|
This commit upgrades github.com/containerd/typeurl to use typeurl.Any. The interface hides gogo/protobuf/types.Any from containerd's Go client. Signed-off-by: Kazuyoshi Kato <katokazu@amazon.com>
|
Build succeeded.
|
dmcgowan
approved these changes
Mar 24, 2022
estesp
approved these changes
Mar 25, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
None yet
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
This commit upgrades github.com/containerd/typeurl to use typeurl.Any.
The interface hides gogo/protobuf/types.Any from containerd's Go client.
Signed-off-by: Kazuyoshi Kato katokazu@amazon.com