| CARVIEW |
Select Language
HTTP/2 200
date: Sat, 26 Jul 2025 11:07:59 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=273.791937,conversation_content-fragment;desc="conversation_content fragment";dur=606.757514,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=272.516436,nginx;desc="NGINX";dur=0.641426,glb;desc="GLB";dur=100.796506
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: a2eb102
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=FAfxlw8NTintX210DR1ZThYrP5RjJ0SzsyFPxJBY%2BFJfigmK1LXAYCq%2Br%2FPfqpIl5jpeS0seNKXG1cMS9OlNt2bGA53JYIm4Ik3O%2B%2FGUNk8wIdajB7giD4a%2BUZXa2gDYRXwuyDdmZLXVTyw5KHHweHR6GOn%2B18QOilqjpnoUYwaC73gC4Og0V2qTdg%2FIJu1QxKS3TFZiKkHaT1Q6BypGYa6pFPjKe3VgqerISGOZEVJWU6HLes3FCldz922YVhe3Uw7JsP1qAKwErTOb19%2FWYg%3D%3D--0W6pqWAIp55yJeqe--BC7i%2BfCxrVn2sv%2FphFKPPg%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.1674638163.1753528078; Path=/; Domain=github.com; Expires=Sun, 26 Jul 2026 11:07:58 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Sun, 26 Jul 2026 11:07:58 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: C64A:1FA760:4BCC31:635CAF:6884B70E
Skip tty critest testcase on Windows Server 2022 by dcantah · Pull Request #6698 · containerd/containerd · GitHub
dcantah
force-pushed
the
skip-windows-critest-tty
branch
from
March 21, 2022 14:32
dcantah
force-pushed
the
skip-windows-critest-tty
branch
from
March 21, 2022 16:11
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Skip tty critest testcase on Windows Server 2022 #6698
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Skipping CI for Draft Pull Request. |
|
Build succeeded.
|
jterry75
approved these changes
Mar 18, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
kzys
approved these changes
Mar 18, 2022
|
Had this on draft as I was out most of the day and wouldn't be able to fix anything if it failed 😄. Doesn't seem like this actually skipped the test even though the if condition should definitely have been entered.. Looking |
|
Oh, I didn't notice this PR until now, and just finished throwing together the same idea (but I was lazy and just skipped the test on all Windows versions, so this PR is better). I suspect the reason it didn't skip is that it's |
|
@TBBle Oh duh, changing shortly |
dcantah
force-pushed
the
skip-windows-critest-tty
branch
from
f6f54d1 to
93af84c
Compare
|
Build succeeded.
|
Skip the 'runtime should support exec with tty=true and stdin=true' test for now as it's exceedingly flaky only on Ws2022.. Doesn't seem to reproduce on a local ws2022 machine, but don't want to keep the CI red while we investigate. Signed-off-by: Daniel Canter <dcanter@microsoft.com>
dcantah
force-pushed
the
skip-windows-critest-tty
branch
from
93af84c to
e9bb9c3
Compare
|
Looks like either --ginkgo.skip or -ginkgo-skip is accepted.. weird. But the issue just lied in how it was being parsed. Should work now, will wait for CI to complete to undraft |
|
looks like it worked: |
estesp
approved these changes
Mar 21, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
kzys
approved these changes
Mar 21, 2022
|
Build succeeded.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
None yet
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
Skip the 'runtime should support exec with tty=true and stdin=true' test
for now as it's exceedingly flaky only on Ws2022.. Doesn't seem to reproduce
on a local ws2022 machine, but don't want to keep the CI red while we
investigate.