You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The GitHub Action is unstable especially on Windows (see #6618).
This change may not address the issue itself, but using the latest
version makes reporting the upstream the issue easier.
The reason will be displayed to describe this comment to others. Learn more.
Seems like a good change to me. A quick check of the golangci-lint release notes suggests staticcheck wasn't changed and nothing else jumped out at me that would help with the flakiness, but as long as it passes, being on a more-recent version seems good anyway.
The GitHub Action is unstable especially on Windows (see containerd#6618).
This change may not address the issue itself, but using the latest
version makes reporting the upstream the issue easier.
Signed-off-by: Kazuyoshi Kato <katokazu@amazon.com>
A quick check of the golangci-lint release notes suggests staticcheck wasn't changed and nothing else jumped out at me that would help with the flakiness
Summarizing 1 Failure:
[Fail] [k8s.io] Streaming runtime should support streaming interfaces [It] runtime should support exec with tty=true and stdin=true [Conformance]
github.com/kubernetes-sigs/cri-tools/pkg/validate/streaming.go:203
Ran 32 of 39 Specs in 273.408 seconds
FAIL! -- 31 Passed | 1 Failed | 0 Pending | 7 Skipped
but that is a known issue (#6652) and upgrading golangci-lint wouldn't affect this behavior.
Based on some initial investigation, I think this is an issue with the caching golangci-lint-action is doing, which uses https://github.com/actions/cache. It's manifesting as a weird issue with staticcheck, but I don't think staticcheck is doing anything wrong, and I haven't been able to repro the issue locally. I'll share more details on the caching as I learn more.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
estesp
added
the
cherry-picked/1.6.x
The GitHub Action is unstable especially on Windows (see #6618).
This change may not address the issue itself, but using the latest
version makes reporting the upstream the issue easier.
Signed-off-by: Kazuyoshi Kato katokazu@amazon.com