| CARVIEW |
Navigation Menu
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Use version 2 configuration format in docs/PLUGINS.md #6613
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use version 2 configuration format in docs/PLUGINS.md #6613
Conversation
|
Hi @sachaos. Thanks for your PR. I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
sachaos
force-pushed
the
feature/use-version-2-config-in-doc
branch
from
dad2b70 to
c58c7ce
Compare
|
Build succeeded.
|
docs/PLUGINS.md
Outdated
| [plugins.cri.registry] | ||
| [plugins.cri.registry.mirrors] | ||
| [plugins.cri.registry.mirrors."docker.io"] | ||
| [plugins."io.containerd.grpc.v1.cri".registry] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is definitely worth updating, but I wonder if we should just remove the registry section as this is using the now-deprecated pattern for registry configuration? Or simply remove the mirrors/endpoint content and replace it with the config_path setting which is the new configuration method for registry hosts/mirrors.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the example here is an old one.. and partial.. and there is no explanation about the contents...
Suggest removing the cri parts... and leave cgroups as the example
Maybe mention how to run containerd config default / dump to see the current default / combined config
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggest removing the cri parts... and leave cgroups as the example
Maybe mention how to run containerd config default / dump to see the current default / combined config
I think your suggestion is good.
I'll remove cri part and use this snippet as a short example.
And mention about how to run containerd config default / dump to see the current default / combined config to tell how to get a full example.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Signed-off-by: Takumasa Sakao <tsakao@zlab.co.jp>
sachaos
force-pushed
the
feature/use-version-2-config-in-doc
branch
from
c58c7ce to
03a5e64
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ok-to-test
thaJeztah
added
the
cherry-picked/1.6.x
I think we are recommending the version 2 configuration file format.
docs/PLUGINS.md is formatted as version 1, which can be confusing.
So I fixed the documentation.
Signed-off-by: Takumasa Sakao tsakao@zlab.co.jp