You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
BTW, should we enable cgroupsv2 integration test in CI?
We have cgroups v2 testing happening in 2 places, both by running a nested VM running Fedora 35:
the unit tests in the containerd/cgroups project run in a VM with v2 enabled
here in the main containerd project, the 2 jobs starting with "CI / CGroupsV2 - ..." in the name run the tests with v2 enabled (via Fedora 35 in a VM).
here in the main containerd project, the 2 jobs starting with "CI / CGroupsV2 - ..." in the name run the tests with v2 enabled (via Fedora 35 in a VM).
Yes, but only integration test(code in integration/client) has been run. CRI integration is not.
here in the main containerd project, the 2 jobs starting with "CI / CGroupsV2 - ..." in the name run the tests with v2 enabled (via Fedora 35 in a VM).
Yes, but only integration test(code in integration/client) has been run. CRI integration is not.
two cri integration buckets are available 1) kubernetes-sigs/cri-tools .. critest and 2) containerd/script/test/cri-integration.sh
Don't think we've tried containerd/script integration yet with v2 enabled in fedora..
Also not sure how much of CGroupsV2 is being tested right now in the k8s prow driven node e2e bucket. They've had some features enable now so I would expect some buckets to be there.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fuweid
added
cherry-picked/1.6.x
TestUpdateContainerResources_MemoryLimit still uses old method to
check memlimit in cgroup.
BTW, should we enable cgroupsv2 integration test in CI?