You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Maybe it should just say a recent version of go because we are pretty good at updating the version to stay current. This will be out of date soon again.
Maybe it should just say a recent version of go because we are pretty good at updating the version to stay current. This will be out of date soon again.
Wait, didn't I actually change it to say "a recent version of Go" 😆
I added the current required minimum (due to our use of specific methods in Go standard libs) as a side note but the focus is now just that it's a "recent version of Go". Our minimum can definitely change in the future, but hopefully we'll catch that.
@estesp - LOL. I get what you were trying to do now. You expect the minimum to not change very often but leave the "recent version" out of that statement :). For sure confused me the first time I read it. This is good.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Phil Estes estesp@amazon.com