| CARVIEW |
Select Language
HTTP/2 200
date: Sat, 26 Jul 2025 10:34:07 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=271.016717,conversation_content-fragment;desc="conversation_content fragment";dur=815.06459,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=247.980559,nginx;desc="NGINX";dur=0.734326,glb;desc="GLB";dur=101.16731
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: a2eb102
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=zkL8%2FlR%2FXvWnwPGVd1146YjyEs4NExkFsrOEG0SZ1ufyDC8stL2yNlWJy7%2Bk6P2go9Pl3YmWEbTg3BqmGVcF5JRSZjRNJoHchYPIWk74X7G0QpX6JxrW2bHQKqNzxyGtHTZpsSCLHTIQ72KzQOcu4F0quDcZvDjWCsNa8xaYbM0eJusy8H3yPp4AroKkbh1%2FXmbNoFn2OUkWFy%2BbjdZ10S6VDPchtgAkodFusYV%2FZ64p3dyug%2Brw6WwgH3n98JUyNwsTeHtVW6ahTMXPcSssjQ%3D%3D--GEYNMWA%2Bh04TVQ8b--ZPzxuv2cKrTnROX8%2BWi0lQ%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.739036878.1753526046; Path=/; Domain=github.com; Expires=Sun, 26 Jul 2026 10:34:06 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Sun, 26 Jul 2026 10:34:06 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: E360:29FD1F:462ECF:5CAB88:6884AF1E
runtime: deprecate runc --criu / -criu-path option by thaJeztah · Pull Request #6496 · containerd/containerd · GitHub
thaJeztah
force-pushed
the
deprecate_criu_opt
branch
from
January 31, 2022 13:39
thaJeztah
force-pushed
the
deprecate_criu_opt
branch
from
January 31, 2022 13:42
thaJeztah
force-pushed
the
deprecate_criu_opt
branch
from
March 23, 2022 13:43
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
runtime: deprecate runc --criu / -criu-path option #6496
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thaJeztah
force-pushed
the
deprecate_criu_opt
branch
from
4cf4344 to
0ecad97
Compare
|
FWIW, I noticed various |
thaJeztah
force-pushed
the
deprecate_criu_opt
branch
from
0ecad97 to
598b386
Compare
|
@thaJeztah That's odd. I have touched a bunch of protoc/protobuild stuff, but these changes shouldn't be reached to containerd automatically. |
kzys
approved these changes
Jan 31, 2022
AkihiroSuda
reviewed
Feb 1, 2022
| @@ -75,7 +75,7 @@ func init() { | |||
| flag.StringVar(&addressFlag, "address", "", "grpc address back to main containerd") | |||
| flag.StringVar(&workdirFlag, "workdir", "", "path used to storge large temporary data") | |||
| flag.StringVar(&runtimeRootFlag, "runtime-root", process.RuncRoot, "root directory for the runtime") | |||
| flag.StringVar(&criuFlag, "criu", "", "path to criu binary") | |||
| flag.StringVar(&criuFlag, "criu", "", "path to criu binary (deprecated: do not use)") | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The entire shim v1 itself is already deprecated, so maybe this message isn't necessary
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I doubt many people will use it manually from the command-line, but when running the command, it's not printed that it's deprecated, and I think it's useful to at least make it visible that the option itself should not be used?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The v1 shim is deprecated but working. The flag is deprecated and it doesn't work (ignored). So I'd like to keep the message.
mxpv
approved these changes
Feb 22, 2022
estesp
approved these changes
Feb 23, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
@AkihiroSuda Looks good to merge? |
|
Needs rebase |
|
You are right. I was assuming that GitHub shows a list of conflicted files when it needs rebase. Where does that go? :( |
I think it performs that check "lazily" (so when you open the page), and it sometimes takes some time to show up. Would be great if they did so "pro-actively" and added a visible warning in overviews (and possibly allowing to filter on it (etc)) I'll try to find some time to rebase tomorrow |
|
@thaJeztah can you please rebase this? |
runc option --criu is now ignored (with a warning), and the option will be removed entirely in a future release. Users who need a non- standard criu binary should rely on the standard way of looking up binaries in $PATH. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
force-pushed
the
deprecate_criu_opt
branch
from
598b386 to
d2013d2
Compare
|
Rebased đź‘Ť |
|
Build succeeded.
|
|
Build succeeded.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
None yet
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
relates to:
runc option --criu is now ignored (with a warning), and the option will be
removed entirely in a future release. Users who need a non- standard criu
binary should rely on the standard way of looking up binaries in $PATH.