| CARVIEW |
Select Language
HTTP/2 200
date: Fri, 25 Jul 2025 18:57:25 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=313.147346,conversation_content-fragment;desc="conversation_content fragment";dur=1290.389492,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=345.189074,nginx;desc="NGINX";dur=1.197255,glb;desc="GLB";dur=102.019255
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: a2eb102
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=bs%2BpsXAly21YjERcZSTHanv4wo7e7n5cqzDx4aw4u3Xb8jfrm7jBpbxRI9Gd6MeU84B6%2Flp4eVZTxCGHyxLWAwFrO3kTj2ddG4Xi9mT4%2FwQIComVTm7K8CVJfozSSNOXZZx1sFGcbPez45NW%2FTcPpQe%2BxEJ9ANr%2BwQ2d%2BMSCbj7fJI9mC7ZEGvY9xKSyd%2Ft8NfzPt05bDCpZxdlW4pDXsqfn8eMW0R%2BgLzLCbZkEuBrft9moisCaLQjAr7bpgUbaSu%2B8NV7lFGuEx9czAEOeyw%3D%3D--ohW59SYyvkSebf6M--VCl65uBjop4DarELzpuApA%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.776769357.1753469844; Path=/; Domain=github.com; Expires=Sat, 25 Jul 2026 18:57:24 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Sat, 25 Jul 2026 18:57:24 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: B296:370876:1FBAA:290EA:6883D394
containerd-shim-runc-v2: return init pid when clean dead shim by zvier · Pull Request #6452 · containerd/containerd · GitHub
fuweid
added
the
cherry-pick/1.6.x
Change to be cherry picked to release/1.6 branch
label
Feb 20, 2022
fuweid
added
cherry-picked/1.5.x
PR commits are cherry-picked into release/1.5 branch
cherry-picked/1.6.x
PR commits are cherry-picked into release/1.6 branch
and removed
cherry-pick/1.5.x
cherry-pick/1.6.x
Change to be cherry picked to release/1.6 branch
labels
Feb 24, 2022
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
containerd-shim-runc-v2: return init pid when clean dead shim #6452
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @zvier. Thanks for your PR. I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
related #6402 |
|
Build succeeded.
|
kzys
reviewed
Jan 20, 2022
|
Build succeeded.
|
If containerd-shim-runc-v2 process dead abnormally, such as received kill 9 signal, panic or other unkown reasons, the containerd-shim-runc-v2 server can not reap runc container and forward init process exit event. This will lead the container leaked in dockerd. When shim dead, containerd will clean dead shim, here read init process pid and forward exit event with pid at the same time. Signed-off-by: Jeff Zvier <zvier20@gmail.com>
|
Build succeeded.
|
|
@kzys Hello, I had improved this PR last week, can you take a look again ? |
kzys
requested changes
Jan 31, 2022
Comment on lines
+274
to
+276
| if err != nil { | ||
| log.G(ctx).WithError(err).Warn("failed to read init pid file") | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about returning this error instead of logging? The function should return either a valid value or error.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This function is used to cleanup the resource, which is handled in command-line.
It should not return error here.
|
@kzys Hello, please review this PR agagin ? |
fuweid
approved these changes
Feb 9, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM on Green.
Tested in my local
# Terminal 1
2022-02-09 14:59:07.994652691 +0000 UTC moby /tasks/exit {"container_id":"8857863cb748d2835781232a7d99e5ba4c0c497f6210513490b4add719993680","id":"8857863cb748d2835781232a7d99e5ba4c0c497f6210513490b4add719993680","pid":206640,"exit_status":137,"exited_at":"2022-02-09T14:59:07.993201143Z"}
2022-02-09 14:59:07.994680201 +0000 UTC moby /tasks/delete {"container_id":"8857863cb748d2835781232a7d99e5ba4c0c497f6210513490b4add719993680","pid":206640,"exit_status":137,"exited_at":"2022-02-09T14:59:07.993201143Z"}
2022-02-09 14:59:08.186136836 +0000 UTC moby /containers/delete {"id":"8857863cb748d2835781232a7d99e5ba4c0c497f6210513490b4add719993680"}
# Terminal 2
âžś containerd git:(review-6452) docker run -d busybox sleep 1d
8857863cb748d2835781232a7d99e5ba4c0c497f6210513490b4add719993680
âžś containerd git:(review-6452) ps -ef | grep sleep
root 206640 206619 0 22:58 ? 00:00:00 sleep 1d
chaofan 206700 152304 0 22:59 pts/0 00:00:00 grep --color=auto --exclude-dir=.bzr --exclude-dir=CVS --exclude-dir=.git --exclude-dir=.hg --exclude-dir=.svn --exclude-dir=.idea --exclude-dir=.tox sleep
âžś containerd git:(review-6452) sudo pkill -9 containerd-shim
âžś containerd git:(review-6452) docker ps -a | grep 88578
8857863cb748 busybox "sleep 1d" 2 minutes ago Exited (137) About a minute ago relaxed_leakey
AkihiroSuda
approved these changes
Feb 9, 2022
|
/ok-to-test |
|
@dmcgowan Hello，can you review this PR ? |
|
/retest |
mxpv
approved these changes
Feb 16, 2022
fuweid
added
the
cherry-pick/1.6.x
This was referenced Feb 20, 2022
fuweid
added
cherry-picked/1.5.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
cherry-picked/1.5.x
PR commits are cherry-picked into release/1.5 branch
cherry-picked/1.6.x
PR commits are cherry-picked into release/1.6 branch
ok-to-test
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
If containerd-shim-runc-v2 process dead abnormally, such as received
kill -s 9 signal, panic or other unkown reasons, the containerd-shim-runc-v2
server can not reap runc container and forward init process exit event.
This will lead the container leaked in dockerd. When shim dead, containerd
will clean dead shim, here read init process pid and forward exit event
with pid at the same time.
Signed-off-by: Jeff Zvier zvier20@gmail.com