| CARVIEW |
Navigation Menu
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
integration: Adds Windows equivalent for TestSandboxRemoveWithoutIPLeakage #6180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hi @claudiubelu. Thanks for your PR. I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Build succeeded.
|
claudiubelu
force-pushed
the
integration/windows-ip-leak
branch
from
937210b to
a50ec48
Compare
|
Build succeeded.
|
|
@claudiubelu What's the status of this? I see you expect the test to fail, what should we be doing with this PR? Are we waiting for a fix so the test passes? |
Sounds like an issue to me. We should find a fix for it, and merge this PR afterwards to test against it, so we're sure we don't regress. This currently only checks azure-vnet-ipam, but other CNIs should be checked as well. |
|
Can you please rebase to test with the latest test changes |
…akage Adds an equivalent TestSandboxRemoveWithoutIPLeakage for Windows, in which we assert that the IPs are not leaked when a Pod's HNS namespace dissapears and the Pod is deleted afterwards. Signed-off-by: Claudiu Belu <cbelu@cloudbasesolutions.com>
claudiubelu
force-pushed
the
integration/windows-ip-leak
branch
from
a50ec48 to
894af07
Compare
Done. /cc @gabriel-samfira |
|
@claudiubelu: GitHub didn't allow me to request PR reviews from the following users: gabriel-samfira. Note that only containerd members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Build succeeded.
|
|
/ok-to-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| if !strings.Contains(string(cniConfig), "azure-vnet-ipam") { | ||
| t.Skip("azure-vnet ipam is not in use") | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This test requires the azure-vnet-ipam CNI plugin? Can this test run outside Azure?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It could run on any infra, but we need a CNI and these tests are running on azure right now I think.
| require.True(t, checkIP(ip)) | ||
|
|
||
| t.Logf("Kill sandbox container") | ||
| require.NoError(t, KillPid(int(info.Pid))) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will only work for process containers but I guess thats fine given the support statement at the moment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SGTM
Adds an equivalent TestSandboxRemoveWithoutIPLeakage for Windows, in which we assert that the IPs are not leaked when a Pod's HNS namespace dissapears and the Pod is deleted afterwards.
The test currently fails, as it seems that the Pod's IP remains "in use" after the Pod is deleted.
Sample output: https://paste.ubuntu.com/p/t47hmr2RyB/
Signed-off-by: Claudiu Belu cbelu@cloudbasesolutions.com