| CARVIEW |
Select Language
HTTP/2 200
date: Fri, 25 Jul 2025 18:45:42 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=325.87741,conversation_content-fragment;desc="conversation_content fragment";dur=949.703362,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=287.701624,nginx;desc="NGINX";dur=0.453193,glb;desc="GLB";dur=101.440225
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: a2eb102
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=uQyaZQdASub2MXtJTWOZkpPAoVmLPZ8P7rDvYgeS3tBOgZPBCPbYDNLYgwNN50UlS%2FoL3TOfQM7cyP6Ncr%2Fo%2B6YBvXaU%2BTbpe%2BRyV0hqhvnuvyifgakvBTlkTdW7x%2FEEyO%2FFWXX4%2Fx3m3STIj6uUb5qRVH1gbPa%2Bly4fZbW4%2Fhr%2Fj3fEIqVJy7gQDu%2BRfQIM77zPpRZkBk4pPWMwXa%2Fs150WUgxzR14%2F%2BeGpnbcb5mwyorM0kUH02JoxEJGETYdWHzwJXgKlDzBCxd4ZBUxsBQ%3D%3D--o4qIuRItyqPIipT4--OrfNI%2BIlLTfQhi58H7C2mA%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.890573557.1753469141; Path=/; Domain=github.com; Expires=Sat, 25 Jul 2026 18:45:41 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Sat, 25 Jul 2026 18:45:41 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: BB64:32DF28:BD00:F372:6883D0D5
go.mod: remove replace, and update github.com/gogo/googleapis v1.4.1 by thaJeztah · Pull Request #5390 · containerd/containerd · GitHub
thaJeztah
changed the title
go.mod: remove replace and update github.com/gogo/googleapis v1.4.1
go.mod: remove replace, and update github.com/gogo/googleapis v1.4.1
Apr 19, 2021
thaJeztah
force-pushed
the
remove_googleapis_replace
branch
from
April 19, 2021 11:43
thaJeztah
force-pushed
the
remove_googleapis_replace
branch
from
April 19, 2021 12:04
thaJeztah
force-pushed
the
remove_googleapis_replace
branch
from
March 23, 2022 15:57
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
go.mod: remove replace, and update github.com/gogo/googleapis v1.4.1 #5390
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thaJeztah
changed the title
thaJeztah
force-pushed
the
remove_googleapis_replace
branch
from
edaa225 to
5a589e6
Compare
|
Build succeeded.
|
thaJeztah
force-pushed
the
remove_googleapis_replace
branch
from
5a589e6 to
432a5ac
Compare
thaJeztah
commented
Apr 19, 2021
|
Build succeeded.
|
14 tasks
dims
approved these changes
Apr 19, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
at least the dependency changes. i don't know about the cc_enable_arenas stuff
estesp
approved these changes
May 7, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
Needs rebase on master |
|
Given all the work being done in protobufs in |
gogo/googleapis has a single dependency (github.com/gogo/protobuf), which is currently the same version as we use, and we have a separate replace for that dependency, so removing this override should not make a difference there. gogo/googleapis v1.4.1 Includes updated protos with the gogo/protobuf fixes for [CVE-2021-3121](https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2021-3121) Change logs and diffs for each release: - v1.3.3 generate grpc service for google/longrunning/operations.proto full diff: gogo/googleapis@v1.3.2...v1.3.3 - v1.4.0 Add google geo type full diff: gogo/googleapis@v1.3.3...v1.4.0 - v1.4.1 This release contains sources generated with the version of gogo/protobuf containing a fix for the "skippy peanut butter" issue. full diff: gogo/googleapis@v1.4.0...v1.4.1 Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
force-pushed
the
remove_googleapis_replace
branch
from
432a5ac to
36612d6
Compare
This comment was marked as outdated.
This comment was marked as outdated.
I should be able remove gogo/protobuf from containerd's main branch before 1.7.0. However 1.6.x and other branches would not have the migration changes. So we need to have this change and backport that to other branches. |
|
It's been a while, but for this one I was mostly looking if we could get rid of the replace rules (as they wouldn't be picked up by consumers of the containerd code). I'm never sure which changes are "safe" to pick for all the grpc parts, so eyes are always welcome on this (and if it's possible to do this in 1.6, I think that'd be great of course to reduce the number of replace rules) |
|
Build succeeded.
|
kzys
approved these changes
Mar 23, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
@kzys still looks good after all this time :) LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
None yet
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
relates to the discussion on #5208 (comment) and related to #4974
gogo/googleapis has a single dependency (github.com/gogo/protobuf), which is
currently the same version as we use, and we have a separate replace for that
dependency, so removing this override should not make a difference there.
gogo/googleapis v1.4.1 Includes updated protos with the gogo/protobuf fixes for
CVE-2021-3121
Change logs and diffs for each release:
generate grpc service for google/longrunning/operations.proto
full diff: https://github.com/gogo/googleapis/compare/v1.3.2..v1.3.3
Add google geo type
full diff: https://github.com/gogo/googleapis/compare/v1.3.3..v1.4.0
This release contains sources generated with the version of gogo/protobuf
containing a fix for the "skippy peanut butter" issue.
full diff: https://github.com/gogo/googleapis/compare/v1.4.0..v1.4.1