cri: Image volumes do not work on Windows

**Description**



Creating a container with an image that has a ``VOLUME`` defined in its Dockerfile cannot be created on a Windows node through ``crictl.exe``, but it works without a problem with ``ctr.exe``. This problem does not occur on Linux.

**Steps to reproduce the issue:**

On Windows:

```
# doesn't work with crictl.
crictl --runtime-endpoint=npipe://./pipe//run/containerd-test/containerd pull docker.io/claudiubelu/volume-copy-up:2.1
$POD_ID=(crictl --runtime-endpoint=npipe://./pipe//run/containerd-test/containerd runp .\pod.json)
$CONTAINER_ID=(crictl --runtime-endpoint=npipe://./pipe//run/containerd-test/containerd create $POD_ID .\container-vol.json .\pod.json)

# works with ctr.
ctr.exe --address //./pipe//run/containerd-test/containerd run --rm docker.io/claudiubelu/volume-copy-up:2.1 test-vol-container cmd /S /C "type C:\\test_dir\\test_file"
```

On Linux:

```
./crictl --runtime-endpoint=unix://./run/containerd-test/containerd.sock pull docker.io/claudiubelu/volume-copy-up:2.1
POD_ID=$(./crictl --runtime-endpoint=unix://./run/containerd-test/containerd.sock runp ./pod.json)
CONTAINER_ID=$(./crictl --runtime-endpoint=unix://./run/containerd-test/containerd.sock create $POD_ID ./container-vol-linux.json ./pod.json)
./crictl --runtime-endpoint=unix://./run/containerd-test/containerd.sock start $CONTAINER_ID

ctr --address //./run/containerd-test/containerd.sock image pull docker.io/claudiubelu/volume-copy-up:2.1
ctr --address //./run/containerd-test/containerd.sock run --rm docker.io/claudiubelu/volume-copy-up:2.1 test-vol-container sh -c "cat /test_dir/test_file"
```

Image Dockerfile:

```
ARG BASE

FROM --platform=linux/amd64 busybox as prep

RUN sh -c "mkdir /test_dir; echo test_content > /test_dir/test_file"

FROM $BASE

COPY --from=prep /test_dir /test_dir
VOLUME "/test_dir"
```

pod.json:

```
{
  "metadata": {
    "name": "ready-sandbox",
    "namespace": "default",
    "attempt": 0,
    "uid": "52fdfc072182654f163f5f0f9a621d729566c74d10037c4d7bbb0407d1e2c649"
  },
  "logDirectory": "/tmp"
}
```

container-vol.json:

```
{
  "metadata": {
    "name": "test-vol-container"
  },
  "image": {
    "image": "claudiubelu/volume-copy-up:2.1"
  },
  "command": ["cmd"],
  "args": ["/S", "/C", "\"type C:\\test_dir\\test_file\""]
}
```

container-vol-linux.json:

```
{
  "metadata": {
    "name": "test-vol-container"
  },
  "image": {
    "image": "claudiubelu/volume-copy-up:2.1"
  },
  "command": ["sh"],
  "args": ["-c", "\"cat /test_dir/test_file\""]
}

```



**Describe the results you received:**

Windows output:

```
PS C:\tmp> # doesn't work with crictl.
PS C:\tmp> crictl --runtime-endpoint=npipe://./pipe//run/containerd-test/containerd pull docker.io/claudiubelu/volu
me-copy-up:2.1
Image is up to date for sha256:e910407e38d586f81a19f0661012b786698ede5b46f66341e33da10197b76abc
PS C:\tmp> $POD_ID=(crictl --runtime-endpoint=npipe://./pipe//run/containerd-test/containerd runp .\pod.json)
PS C:\tmp> $CONTAINER_ID=(crictl --runtime-endpoint=npipe://./pipe//run/containerd-test/containerd create $POD_ID .
\container-vol.json .\pod.json)
time="2021-06-29T13:17:18Z" level=fatal msg="creating container: rpc error: code = Unknown desc = failed to generate container \"0147cb3924012562710441f3a9b2caddddf72b5056f0d73de8b9ebcc133fdf9e\" spec: failed to generate spec: failed to stat \"C:\\\\Program Files\\\\Git\\\\var\\\\lib\\\\containerd-test\\\\io.containerd.grpc.v1.cri\\\\containers\\\\0147cb3924012562710441f3a9b2caddddf72b5056f0d73de8b9ebcc133fdf9e\\\\volumes\\\\e9ef85a305f4906b2932e9ca7848a728047de9e8981ec1739f8bed5fd619460d\": CreateFile C:\\Program Files\\Git\\var\\lib\\containerd-test\\io.containerd.grpc.v1.cri\\containers\\0147cb3924012562710441f3a9b2caddddf72b5056f0d73de8b9ebcc133fdf9e\\volumes\\e9ef85a305f4906b2932e9ca7848a728047de9e8981ec1739f8bed5fd619460d: The system cannot find the path specified."
PS C:\tmp>
PS C:\tmp> # works with ctr.
PS C:\tmp> ctr.exe --address //./pipe//run/containerd-test/containerd run --rm docker.io/claudiubelu/volume-copy-up
:2.1 test-vol-container cmd /S /C "type C:\\test_dir\\test_file"
test_content
```


**Describe the results you expected:**

Linux Output:

```
+ ./crictl --runtime-endpoint=unix://./run/containerd-test/containerd.sock pull docker.io/claudiubelu/volume-copy-up:2.1
Image is up to date for sha256:13019b279c229f09242b2db1378ff7aa499183bc7ab1332d4b04e36896656eab
++ ./crictl --runtime-endpoint=unix://./run/containerd-test/containerd.sock runp ./pod.json
+ POD_ID=a860dfa592c4cf890b1980d2f41403ce5a9c2eb0ce1a512c69cc1852bcfe5372
++ ./crictl --runtime-endpoint=unix://./run/containerd-test/containerd.sock create a860dfa592c4cf890b1980d2f41403ce5a9c2eb0ce1a512c69cc1852bcfe5372 ./container-vol-linux.json ./pod.json
+ CONTAINER_ID=afd069d513d96e271b51cbc948b534ffb77c43f206780ba9ef25e7a946562428
+ ./crictl --runtime-endpoint=unix://./run/containerd-test/containerd.sock start afd069d513d96e271b51cbc948b534ffb77c43f206780ba9ef25e7a946562428
afd069d513d96e271b51cbc948b534ffb77c43f206780ba9ef25e7a946562428
+ ctr --address //./run/containerd-test/containerd.sock image pull docker.io/claudiubelu/volume-copy-up:2.1
docker.io/claudiubelu/volume-copy-up:2.1:                                         resolved       |++++++++++++++++++++++++++++++++++++++|
index-sha256:230b77940bebc9de34f00df5698e65a43478eed6a6dc33ee82e711e1c7691b48:    exists         |++++++++++++++++++++++++++++++++++++++|
manifest-sha256:28b77b5a4f26734d22f7d4f7082addabaff8d4d366b705e67d43a04dafe55d96: exists         |++++++++++++++++++++++++++++++++++++++|
layer-sha256:df0e4ccb814be1f845a2d8e385e61545c20ae0aa73cc2438c50cf24adcb3abbc:    exists         |++++++++++++++++++++++++++++++++++++++|
config-sha256:13019b279c229f09242b2db1378ff7aa499183bc7ab1332d4b04e36896656eab:   exists         |++++++++++++++++++++++++++++++++++++++|
layer-sha256:b71f96345d44b237decc0c2d6c2f9ad0d17fde83dad7579608f1f0764d9686f2:    exists         |++++++++++++++++++++++++++++++++++++++|
elapsed: 1.7 s                                                                    total:   0.0 B (0.0 B/s)         
unpacking linux/amd64 sha256:230b77940bebc9de34f00df5698e65a43478eed6a6dc33ee82e711e1c7691b48...
done
+ ctr --address //./run/containerd-test/containerd.sock run --rm docker.io/claudiubelu/volume-copy-up:2.1 test-vol-container sh -c 'cat /test_dir/test_file'
test_content
```



**What version of containerd are you using:**

```
$ containerd --version
containerd github.com/containerd/containerd v1.5.0-153-g0a3a77bc4 0a3a77bc445379851a5c737955411fc9e630c3ce
```

**Any other relevant information (runC version, CRI configuration, OS/Kernel version, etc.):**



<details><summary><code>runc --version</code></summary><br><pre>
$ runc --version

</pre></details>



<details><summary><code>crictl info</code></summary><br><pre>
$ crictl info

```
{
  "status": {
    "conditions": [
      {
        "type": "RuntimeReady",
        "status": true,
        "reason": "",
        "message": ""
      },
      {
        "type": "NetworkReady",
        "status": true,
        "reason": "",
        "message": ""
      }
    ]
  },
  "cniconfig": {
    "PluginDirs": [
      "c:/k/azurecni/bin"
    ],
    "PluginConfDir": "c:/k/azurecni/netconf",
    "PluginMaxConfNum": 1,
    "Prefix": "eth",
    "Networks": [
      {
        "Config": {
          "Name": "azure",
          "CNIVersion": "0.3.0",
          "Plugins": [
            {
              "Network": {
                "type": "azure-vnet",
                "capabilities": {
                  "dns": true,
                  "portMappings": true
                },
                "ipam": {
                  "type": "azure-vnet-ipam"
                },
                "dns": {
                  "nameservers": [
                    "10.0.0.10",
                    "168.63.129.16"
                  ],
                  "search": [
                    "svc.cluster.local"
                  ]
                }
              },
              "Source": "{\"AdditionalArgs\":[{\"Name\":\"EndpointPolicy\",\"Value\":{\"ExceptionList\":[\"10.0.0.0
/8\",\"10.240.0.0/12\"],\"Type\":\"OutBoundNAT\"}},{\"Name\":\"EndpointPolicy\",\"Value\":{\"DestinationPrefix\":\"
10.0.0.0/16\",\"NeedEncap\":true,\"Type\":\"ROUTE\"}},{\"Name\":\"EndpointPolicy\",\"Value\":{\"Action\":\"Block\",
\"Direction\":\"Out\",\"Priority\":200,\"Protocols\":\"6\",\"RemoteAddresses\":\"168.63.129.16/32\",\"RemotePorts\"
:\"80\",\"RuleType\":\"Switch\",\"Type\":\"ACL\"}},{\"Name\":\"EndpointPolicy\",\"Value\":{\"Action\":\"Allow\",\"D
irection\":\"In\",\"Priority\":65500,\"Type\":\"ACL\"}},{\"Name\":\"EndpointPolicy\",\"Value\":{\"Action\":\"Allow\
",\"Direction\":\"Out\",\"Priority\":65500,\"Type\":\"ACL\"}}],\"bridge\":\"azure0\",\"capabilities\":{\"dns\":true
,\"portMappings\":true},\"dns\":{\"Nameservers\":[\"10.0.0.10\",\"168.63.129.16\"],\"Search\":[\"svc.cluster.local\
"]},\"ipam\":{\"type\":\"azure-vnet-ipam\"},\"mode\":\"bridge\",\"type\":\"azure-vnet\"}"
            }
          ],
          "Source": "{\r\n    \"cniVersion\":  \"0.3.0\",\r\n    \"name\":  \"azure\",\r\n    \"adapterName\":  \"\
",\r\n    \"plugins\":  [\r\n                    {\r\n                        \"type\":  \"azure-vnet\",\r\n
                 \"mode\":  \"bridge\",\r\n                        \"bridge\":  \"azure0\",\r\n
    \"capabilities\":  {\r\n                                             \"portMappings\":  true,\r\n
                               \"dns\":  true\r\n                                         },\r\n
     \"ipam\":  {\r\n                                     \"type\":  \"azure-vnet-ipam\"\r\n
          },\r\n                        \"dns\":  {\r\n                                    \"Nameservers\":  [\r\n
                                                       \"10.0.0.10\",\r\n
              \"168.63.129.16\"\r\n                                                    ],\r\n
              \"Search\":  [\r\n                                                   \"svc.cluster.local\"\r\n
                                        ]\r\n                                },\r\n                        \"Additi
onalArgs\":  [\r\n                                               {\r\n
      \"Name\":  \"EndpointPolicy\",\r\n                                                   \"Value\":  {\r\n
                                                          \"Type\":  \"OutBoundNAT\",\r\n
                                       \"ExceptionList\":  [\r\n
                                    \"10.0.0.0/8\",\r\n
                           \"10.240.0.0/12\"\r\n
                ]\r\n                                                             }\r\n
                   },\r\n                                               {\r\n
             \"Name\":  \"EndpointPolicy\",\r\n                                                   \"Value\":  {\r\n
                                                                 \"Type\":  \"ROUTE\",\r\n
                                        \"DestinationPrefix\":  \"10.0.0.0/16\",\r\n
                                  \"NeedEncap\":  true\r\n
    }\r\n                                               },\r\n                                               {\r\n
                                                  \"Name\":  \"EndpointPolicy\",\r\n
                    \"Value\":  {\r\n                                                                 \"Type\":  \"
ACL\",\r\n                                                                 \"Protocols\":  \"6\",\r\n
                                                   \"Action\":  \"Block\",\r\n
                            \"Direction\":  \"Out\",\r\n
      \"RemoteAddresses\":  \"168.63.129.16/32\",\r\n
   \"RemotePorts\":  \"80\",\r\n                                                                 \"Priority\":  200
,\r\n                                                                 \"RuleType\":  \"Switch\"\r\n
                                             }\r\n                                               },\r\n
                                   {\r\n                                                   \"Name\":  \"EndpointPol
icy\",\r\n                                                   \"Value\":  {\r\n
                            \"Type\":  \"ACL\",\r\n
 \"Action\":  \"Allow\",\r\n                                                                 \"Direction\":  \"In\"
,\r\n                                                                 \"Priority\":  65500\r\n
                                        }\r\n                                               },\r\n
                              {\r\n                                                   \"Name\":  \"EndpointPolicy\"
,\r\n                                                   \"Value\":  {\r\n
                       \"Type\":  \"ACL\",\r\n                                                                 \"Ac
tion\":  \"Allow\",\r\n                                                                 \"Direction\":  \"Out\",\r\
n                                                                 \"Priority\":  65500\r\n
                                    }\r\n                                               }\r\n
                     ]\r\n                    }\r\n                ]\r\n}\r\n"
        },
        "IFName": "eth0"
      }
    ]
  },
  "config": {
    "containerd": {
      "snapshotter": "windows",
      "defaultRuntimeName": "default",
      "defaultRuntime": {
        "runtimeType": "io.containerd.runhcs.v1",
        "runtimeEngine": "",
        "PodAnnotations": null,
        "ContainerAnnotations": null,
        "runtimeRoot": "",
        "options": {
          "Debug": true,
          "DebugType": 2,
          "SandboxImage": "mcr.microsoft.com/oss/kubernetes/pause:3.4.1-windows-1809-amd64",
          "SandboxIsolation": 0,
          "SandboxPlatform": "windows/amd64"
        },
        "privileged_without_host_devices": false,
        "baseRuntimeSpec": ""
      },
      "untrustedWorkloadRuntime": {
        "runtimeType": "",
        "runtimeEngine": "",
        "PodAnnotations": null,
        "ContainerAnnotations": null,
        "runtimeRoot": "",
        "options": null,
        "privileged_without_host_devices": false,
        "baseRuntimeSpec": ""
      },
      "runtimes": {
        "default": {
          "runtimeType": "io.containerd.runhcs.v1",
          "runtimeEngine": "",
          "PodAnnotations": null,
          "ContainerAnnotations": null,
          "runtimeRoot": "",
          "options": {
            "Debug": true,
            "DebugType": 2,
            "SandboxImage": "mcr.microsoft.com/oss/kubernetes/pause:3.4.1-windows-1809-amd64",
            "SandboxIsolation": 0,
            "SandboxPlatform": "windows/amd64"
          },
          "privileged_without_host_devices": false,
          "baseRuntimeSpec": ""
        },
        "runhcs-wcow-process": {
          "runtimeType": "io.containerd.runhcs.v1",
          "runtimeEngine": "",
          "PodAnnotations": null,
          "ContainerAnnotations": null,
          "runtimeRoot": "",
          "options": {
            "Debug": true,
            "DebugType": 2,
            "SandboxImage": "mcr.microsoft.com/oss/kubernetes/pause:3.4.1-windows-1809-amd64",
            "SandboxPlatform": "windows/amd64"
          },
          "privileged_without_host_devices": false,
          "baseRuntimeSpec": ""
        }
      },
      "noPivot": false,
      "disableSnapshotAnnotations": false,
      "discardUnpackedLayers": true
    },
    "cni": {
      "binDir": "c:/k/azurecni/bin",
      "confDir": "c:/k/azurecni/netconf",
      "maxConfNum": 1,
      "confTemplate": ""
    },
    "registry": {
      "configPath": "",
      "mirrors": {
        "docker.io": {
          "endpoint": [
            "https://registry-1.docker.io"
          ]
        }
      },
      "configs": null,
      "auths": null,
      "headers": null
    },
    "imageDecryption": {
      "keyModel": "node"
    },
    "disableTCPService": true,
    "streamServerAddress": "127.0.0.1",
    "streamServerPort": "0",
    "streamIdleTimeout": "4h0m0s",
    "enableSelinux": false,
    "selinuxCategoryRange": 0,
    "sandboxImage": "mcr.microsoft.com/oss/kubernetes/pause:3.4.1-windows-1809-amd64",
    "statsCollectPeriod": 10,
    "systemdCgroup": false,
    "enableTLSStreaming": false,
    "x509KeyPairStreaming": {
      "tlsCertFile": "",
      "tlsKeyFile": ""
    },
    "maxContainerLogSize": 16384,
    "disableCgroup": false,
    "disableApparmor": false,
    "restrictOOMScoreAdj": false,
    "maxConcurrentDownloads": 3,
    "disableProcMount": false,
    "unsetSeccompProfile": "",
    "tolerateMissingHugetlbController": false,
    "disableHugetlbController": false,
    "ignoreImageDefinedVolumes": false,
    "netnsMountsUnderStateDir": false,
    "containerdRootDir": "C:\\Program Files\\Git\\var\\lib\\containerd-test",
    "containerdEndpoint": "//./pipe//run/containerd-test/containerd",
    "rootDir": "C:\\Program Files\\Git\\var\\lib\\containerd-test\\io.containerd.grpc.v1.cri",
    "stateDir": "C:\\Program Files\\Git\\run\\containerd-test\\io.containerd.grpc.v1.cri"
  },
  "golang": "go1.16.4",
  "lastCNILoadStatus": "OK"
}
```

</pre></details>


<details><summary><code>uname -a</code></summary><br><pre>
$ uname -a

</pre></details>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

cri: Image volumes do not work on Windows #5671

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

cri: Image volumes do not work on Windows #5671

Description

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions