Merge pull request #6331 from ningmingxiao/dev2

estesp · web-flow · commit c79f501f39e9 · 2022-02-22T17:32:09.000-05:00
fix Implicit memory aliasing in for loop
diff --git a/containerstore.go b/containerstore.go
@@ -189,6 +189,7 @@ func containersFromProto(containerspb []containersapi.Container) []containers.Co
 	var containers []containers.Container
 
 	for _, container := range containerspb {
+		container := container
 		containers = append(containers, containerFromProto(&container))
 	}
 
diff --git a/image_store.go b/image_store.go
@@ -129,6 +129,7 @@ func imagesFromProto(imagespb []imagesapi.Image) []images.Image {
 	var images []images.Image
 
 	for _, image := range imagespb {
+		image := image
 		images = append(images, imageFromProto(&image))
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -189,6 +189,7 @@ func containersFromProto(containerspb []containersapi.Container) []containers.Co`
`189`	`189`	`var containers []containers.Container`
`190`	`190`
`191`	`191`	`for _, container := range containerspb {`
	`192`	`+ container := container`
`192`	`193`	`containers = append(containers, containerFromProto(&container))`
`193`	`194`	`}`
`194`	`195`
Original file line number	Diff line number	Diff line change
`@@ -129,6 +129,7 @@ func imagesFromProto(imagespb []imagesapi.Image) []images.Image {`
`129`	`129`	`var images []images.Image`
`130`	`130`
`131`	`131`	`for _, image := range imagespb {`
	`132`	`+ image := image`
`132`	`133`	`images = append(images, imageFromProto(&image))`
`133`	`134`	`}`
`134`	`135`