Add debug log when transfer returns not implemented

dmcgowan · k8s-infra-cherrypick-robot · commit 0c3cd8a99529 · 2025-06-04T05:41:24.000Z
Currently the error details are not included in the output error and
there is no log. One of the reasons a the transferer was skipped could
be do to a specific component which is not implemented (such as trying
to use erofs differ) or unsupported image (pulling schema1). This
information is useful to find a bad configuration.

Signed-off-by: Derek McGowan &lt;derek@mcg.dev&gt;
diff --git a/plugins/services/transfer/service.go b/plugins/services/transfer/service.go
@@ -138,6 +138,7 @@ func (s *service) Transfer(ctx context.Context, req *transferapi.TransferRequest
 		} else if !errdefs.IsNotImplemented(err) {
 			return nil, errgrpc.ToGRPC(err)
 		}
+		log.G(ctx).WithError(err).Debugf("transfer not implemented for %T to %T", src, dst)
 	}
 	return nil, status.Errorf(codes.Unimplemented, "method Transfer not implemented for %s to %s", req.Source.GetTypeUrl(), req.Destination.GetTypeUrl())
 }

Original file line number	Diff line number	Diff line change
`@@ -138,6 +138,7 @@ func (s service) Transfer(ctx context.Context, req transferapi.TransferRequest`
`138`	`138`	`} else if !errdefs.IsNotImplemented(err) {`
`139`	`139`	`return nil, errgrpc.ToGRPC(err)`
`140`	`140`	`}`
	`141`	`+ log.G(ctx).WithError(err).Debugf("transfer not implemented for %T to %T", src, dst)`
`141`	`142`	`}`
`142`	`143`	`return nil, status.Errorf(codes.Unimplemented, "method Transfer not implemented for %s to %s", req.Source.GetTypeUrl(), req.Destination.GetTypeUrl())`
`143`	`144`	`}`