| CARVIEW |
Select Language
HTTP/2 200
date: Fri, 25 Jul 2025 18:03:04 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=392.618903,conversation_content-fragment;desc="conversation_content fragment";dur=681.260615,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=314.812705,nginx;desc="NGINX";dur=0.589467,glb;desc="GLB";dur=101.29248
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: a2eb102
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=i4eNPDPloeau9M%2FVui9K9sj3ki0BTj8eisJZMjw3U7wSzrf66L%2Bm08OaD4%2BynTjDRKWDOZVi8tE0O69nxreZIv6eL%2BDYJHU8HZAQvMu5gk%2BTvXh4oOw%2Bjr%2FizaDD4p%2FD8ZKT9W%2BBQwneg6dStl9q9B4UCHLihUSvlBra5x80V7EI7vjKD5bG%2FYsq%2BfRJF%2FfvB4xgtYWbrTVfTZwGod9wdJcmcjxpECWpiU%2F18W0bVpufFTlid2yeu9wlLOxnggnLHlc8ATpkoVQGZVDO%2BTGAFA%3D%3D--BeICtPlo%2F2kUr2zU--rEkTRDVo7qDsrpzgT%2FldOQ%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.964309943.1753466583; Path=/; Domain=github.com; Expires=Sat, 25 Jul 2026 18:03:03 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Sat, 25 Jul 2026 18:03:03 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: A358:14885C:9B5AF:BEA83:6883C6D7
feat(v2): Support cgroup.MoveTo in cgroupv2 manager by yaoyinnan · Pull Request #235 · containerd/cgroups · GitHub
yaoyinnan
changed the title
Cgroup v2: Support cgroup.MoveTo in cgroupv2 manager
feat(v2): Support cgroup.MoveTo in cgroupv2 manager
Jun 8, 2022
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 244
feat(v2): Support cgroup.MoveTo in cgroupv2 manager #235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Provides a method for the cgroup v2 manager to support moving processes to a specified cgroup. Fixes: containerd#234 Signed-off-by: yaoyinnan <yaoyinnan@foxmail.com>
yaoyinnan
changed the title
|
@estesp Please help me review this PR. kata-containers/kata-containers#4397 needs this PR to be merged. Thanks. |
|
Given there is no test, how have you validated this works properly on cgroups v2? I notice that it works differently than the v1 |
|
@estesp I tested the error in the cgroupv2 environment, the error message contains "no such process", the content is as follows: This MoveTo() method exists in cgroup v1, but does not exist in cgroup v2's Manager. I need to be compatible with this method in order to make Kata compatible with cgroup v1 and cgroup v2 systems. In Kata I tested this function and it works fine. |
estesp
approved these changes
Jun 17, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
@AkihiroSuda Please help me review this PR. Thanks. |
|
@estesp Please help me contact @AkihiroSuda to help me review this PR, the kata-containers/kata-containers#4397 needs to wait for #235 to be merged. Thanks. |
|
Please consider adding a test |
Add unit test TestMoveTo() for manager.MoveTo(). Fixes: containerd#234 Signed-off-by: yaoyinnan <yaoyinnan@foxmail.com>
|
@AkihiroSuda I have added the test. |
AkihiroSuda
approved these changes
Jun 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
None yet
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
Provides a method for the cgroup v2 manager to support moving processes to a specified cgroup.
Fixes: #234
Signed-off-by: yaoyinnan yaoyinnan@foxmail.com