fix: Address CI and linter issues

hashkode · hashkode · commit 99846980a9c0 · 2025-04-07T22:57:52.000+02:00
Corrects Go version mismatch, GitHub Actions permissions, and Go linting errors reported by MegaLinter.

- Bumps Go version in `go.yaml` workflow to 1.24, aligning with `go.mod`.
- Sets default `permissions: read-all` in `go.yaml` and `release.yaml` workflows to resolve Checkov warnings.
- Adds missing package comments to satisfy `revive` linter across multiple internal packages.
diff --git a/.github/workflows/go.yaml b/.github/workflows/go.yaml
@@ -7,18 +7,23 @@ on:
   pull_request:
     branches: [main]
 
+# Define default permissions as read-only
+permissions: read-all
+
 jobs:
   build:
     name: Build & Test
     runs-on: ubuntu-latest
+    env:
+      GOPRIVATE: github.com/co-browser/agent-browser
     steps:
       - name: Check out code
         uses: actions/checkout@v4
 
       - name: Set up Go
         uses: actions/setup-go@v5
         with:
-          go-version: '1.21' # Or your desired Go version
+          go-version: '1.24'
 
       - name: Setup tools
         run: make setup
diff --git a/.github/workflows/release.yaml b/.github/workflows/release.yaml
@@ -6,6 +6,9 @@ on:
     branches:
       - main
 
+# Define default permissions as read-only
+permissions: read-all
+
 jobs:
   release:
     runs-on: ubuntu-latest
diff --git a/internal/app/app.go b/internal/app/app.go
@@ -1,3 +1,4 @@
+// Package app provides the core application setup using Fx.
 package app
 
 import (
diff --git a/internal/backend/database/database.go b/internal/backend/database/database.go
@@ -1 +1,2 @@
+// Package database provides types and functions for database interactions.
 package database
diff --git a/internal/backend/service.go b/internal/backend/service.go
@@ -1 +1,2 @@
+// Package backend provides backend service implementations.
 package backend
diff --git a/internal/config/config.go b/internal/config/config.go
@@ -1 +1,2 @@
+// Package config handles application configuration loading and access.
 package config
diff --git a/internal/log/fx_adapter.go b/internal/log/fx_adapter.go
@@ -1,3 +1,4 @@
+// Package log provides an adapter for Fx logging using zerolog.
 package log
 
 import (
diff --git a/internal/log/log.go b/internal/log/log.go
@@ -1,3 +1,4 @@
+// Package log provides logging utilities and Fx integration.
 package log
 
 import (
diff --git a/internal/mcp/client/client.go b/internal/mcp/client/client.go
@@ -1 +1,2 @@
+// Package client implements the MCP client logic.
 package client
diff --git a/internal/mcp/protocol/protocol.go b/internal/mcp/protocol/protocol.go
@@ -1 +1,2 @@
+// Package protocol defines the MCP protocol structures and constants.
 package protocol
diff --git a/internal/mcp/server.go b/internal/mcp/server.go
@@ -1 +1,2 @@
+// Package mcp implements the MCP server logic.
 package mcp
diff --git a/internal/services/services.go b/internal/services/services.go
@@ -1 +1,2 @@
+// Package services contains core business logic implementations.
 package services
diff --git a/internal/sync/daemon.go b/internal/sync/daemon.go
@@ -1 +1,2 @@
+// Package sync provides synchronization daemon logic.
 package sync
diff --git a/internal/updater/service.go b/internal/updater/service.go
@@ -1 +1,2 @@
+// Package updater provides the application update service logic.
 package updater
diff --git a/internal/web/handlers/ui.go b/internal/web/handlers/ui.go
@@ -1,3 +1,4 @@
+// Package handlers provides HTTP request handlers for the web interface.
 package handlers
 
 import (
diff --git a/internal/web/server.go b/internal/web/server.go
@@ -1,3 +1,4 @@
+// Package web provides web server setup and HTTP utilities.
 package web
 
 import (
@@ -41,9 +42,9 @@ func RegisterWebServerHooks(lifecycle fx.Lifecycle, server *http.Server, logger
 			}()
 			return nil
 		},
-		OnStop: func(ctx context.Context) error {
+		OnStop: func(_ context.Context) error {
 			logger.Info().Msg("Shutting down HTTP server...")
-			return server.Shutdown(ctx)
+			return server.Shutdown(context.Background())
 		},
 	})
 }
diff --git a/scripts/setup.sh b/scripts/setup.sh
@@ -11,12 +11,12 @@ log() {
 
 # Function to print success messages (green)
 echo_success() {
-    printf "\033[0;32m✓ %s\033[0m\n" "$1"
+	printf "\033[0;32m✓ %s\033[0m\n" "$1"
 }
 
 # Function to print warning messages (yellow)
 echo_warn() {
-    printf "\033[0;33mWARN: %s\033[0m\n" "$1"
+	printf "\033[0;33mWARN: %s\033[0m\n" "$1"
 }
 
 log "Starting setup..."
@@ -34,17 +34,17 @@ GOPATH_BIN=$(go env GOPATH)/bin
 
 # Check if GOPATH/bin could be determined
 if [ -z "$GOPATH_BIN" ] || [ "$GOPATH_BIN" = "/bin" ]; then
-    echo_warn "Could not determine GOPATH/bin. Please ensure GOPATH is set correctly."
+	echo_warn "Could not determine GOPATH/bin. Please ensure GOPATH is set correctly."
 else
-    # Use awk to check if GOPATH_BIN is a distinct component in PATH
-    if echo "$PATH" | awk -v path_to_check="$GOPATH_BIN" 'BEGIN { FS=":"; found=0 } { for(i=1; i<=NF; i++) if ($i == path_to_check) { found=1; exit 0 } } END { exit !found }'; then
-        echo_success "$GOPATH_BIN appears to be in your PATH."
-    else
-        echo_warn "$GOPATH_BIN does not appear to be in your PATH."
-        echo "         Please add it to your shell configuration (e.g., .zshrc, .bashrc):"
-        echo "         export PATH=\"$PATH:$GOPATH_BIN\""
-    fi
+	# Use awk to check if GOPATH_BIN is a distinct component in PATH
+	if echo "$PATH" | awk -v path_to_check="$GOPATH_BIN" 'BEGIN { FS=":"; found=0 } { for(i=1; i<=NF; i++) if ($i == path_to_check) { found=1; exit 0 } } END { exit !found }'; then
+		echo_success "$GOPATH_BIN appears to be in your PATH."
+	else
+		echo_warn "$GOPATH_BIN does not appear to be in your PATH."
+		echo "         Please add it to your shell configuration (e.g., .zshrc, .bashrc):"
+		echo "         export PATH=\"$PATH:$GOPATH_BIN\""
+	fi
 fi
 
 # Use printf for the final success message too
-printf "\033[0;32m✓ %s\033[0m\n" "Setup complete." 
+printf "\033[0;32m✓ %s\033[0m\n" "Setup complete."

Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,4 @@`
	`1`	`+// Package app provides the core application setup using Fx.`
`1`	`2`	`package app`
`2`	`3`
`3`	`4`	`import (`
Original file line number	Diff line number	Diff line change
`@@ -1 +1,2 @@`
	`1`	`+// Package database provides types and functions for database interactions.`
`1`	`2`	`package database`
Original file line number	Diff line number	Diff line change
`@@ -1 +1,2 @@`
	`1`	`+// Package backend provides backend service implementations.`
`1`	`2`	`package backend`
Original file line number	Diff line number	Diff line change
`@@ -1 +1,2 @@`
	`1`	`+// Package config handles application configuration loading and access.`
`1`	`2`	`package config`
Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,4 @@`
	`1`	`+// Package log provides an adapter for Fx logging using zerolog.`
`1`	`2`	`package log`
`2`	`3`
`3`	`4`	`import (`
Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,4 @@`
	`1`	`+// Package log provides logging utilities and Fx integration.`
`1`	`2`	`package log`
`2`	`3`
`3`	`4`	`import (`
Original file line number	Diff line number	Diff line change
`@@ -1 +1,2 @@`
	`1`	`+// Package client implements the MCP client logic.`
`1`	`2`	`package client`
Original file line number	Diff line number	Diff line change
`@@ -1 +1,2 @@`
	`1`	`+// Package protocol defines the MCP protocol structures and constants.`
`1`	`2`	`package protocol`