fix: linting

michiosw · michiosw · commit 3af48babea76 · 2025-04-14T17:17:53.000-07:00
diff --git a/internal/mcp/metrics.go b/internal/mcp/metrics.go
@@ -24,20 +24,26 @@ var (
 		Buckets: prometheus.DefBuckets,
 	}, []string{"operation"})
 
+	/* // Remove unused metric
 	mcpToolSyncErrors = promauto.NewCounterVec(prometheus.CounterOpts{
 		Name: "mcp_tool_sync_errors_total",
 		Help: "Total number of tool synchronization errors",
 	}, []string{"operation"})
+	*/
 
-	// API metrics
+	// API metrics - Removed as API client interaction from ConnManager is gone
+	/* // Remove unused metric
 	mcpAPILatency = promauto.NewHistogramVec(prometheus.HistogramOpts{
 		Name:    "mcp_api_latency_seconds",
 		Help:    "Latency of API operations",
 		Buckets: prometheus.DefBuckets,
 	}, []string{"operation"})
+	*/
 
+	/* // Remove unused metric
 	mcpAPIErrors = promauto.NewCounterVec(prometheus.CounterOpts{
 		Name: "mcp_api_errors_total",
 		Help: "Total number of API operation errors",
 	}, []string{"operation"})
+	*/
 )
diff --git a/internal/mcp/server.go b/internal/mcp/server.go
@@ -402,62 +402,6 @@ func connectToRemoteServer(ctx context.Context, logger log.Logger, remote Remote
 	return newConn, nil
 }
 
-// findRemoteServerForTool finds the remote server config for a tool
-func findRemoteServerForTool(toolName string, servers []models.MCPServer) (*RemoteMCPServer, *MCPConnection) {
-	connectionsMutex.RLock()
-	defer connectionsMutex.RUnlock()
-
-	for _, server := range servers {
-		if conn, exists := remoteConnections[server.URL]; exists {
-			for _, tool := range conn.getTools() {
-				if tool.Name == toolName {
-					remote := RemoteMCPServer{
-						URL:  server.URL,
-						Name: server.Name,
-					}
-					return &remote, conn
-				}
-			}
-		}
-	}
-	return nil, nil
-}
-
-// aggregateRemoteTools connects to remote servers and collects their tools
-func aggregateRemoteTools(ctx context.Context, logger log.Logger /*, apiClient *webclient.Client*/) ([]*mcp.Tool, error) {
-	logger.Warn().Msg("aggregateRemoteTools is disabled due to apiClient removal.")
-	return nil, nil // Return empty list
-	/*
-		var tools []*mcp.Tool
-
-		// Get servers from API
-		servers, err := apiClient.ListMCPServers(ctx) // This is the dependency
-		if err != nil {
-			return nil, fmt.Errorf("failed to list servers: %w", err)
-		}
-
-		// Connect to each server and collect tools
-		for _, server := range servers {
-			conn, err := connectToRemoteServer(ctx, logger, RemoteMCPServer{
-				URL:  server.URL,
-				Name: server.Name,
-			})
-			if err != nil {
-				logger.Error().Err(err).Str("url", server.URL).Msg("Failed to connect to remote server")
-				continue
-			}
-
-			// Get tools from this server
-			serverTools := conn.getTools()
-			for i := range serverTools {
-				tools = append(tools, &serverTools[i])
-			}
-		}
-
-		return tools, nil
-	*/
-}
-
 // Start begins managing connections and health checks
 func (cm *ConnectionManager) Start() {
 	cm.mu.Lock()
