CARVIEW |
Select Language
HTTP/2 200
date: Wed, 23 Jul 2025 20:17:21 GMT
content-type: text/html; charset=utf-8
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-repository-download: git clone https://github.com/chakra-core/ChakraCore.git
etag: W/"a455131f0c494344c53c117cb6bb57f9"
cache-control: max-age=0, private, must-revalidate
strict-transport-security: max-age=31536000; includeSubdomains; preload
x-frame-options: deny
x-content-type-options: nosniff
x-xss-protection: 0
referrer-policy: no-referrer-when-downgrade
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=sU9UTaSi3sNG58Yn5m%2FHKvq8Sh%2FrqYPOQIGXhiFeGcTkXk3EBpFbcoRI24F7PWsEAl4XntRVg38Ob%2Bou3VL%2FG292wfWnPOBA9VKCUhNqswECMpyCoQN98lIuisuZNuTy5oVe%2BcgC4SDnkth3xv2iwoSPg9GfBzI4ux8mTJH9EhKUjYHP8jD8%2BZfAMJPnkaI120l8tnPBPErbw6sB4idC4T6LhUi1N%2BIWTA9tYJNsYh18pAER1nEEek9J%2BTzX5595qxws%2FZ8hlFnr%2BOfYx%2FXaDA%3D%3D--pafFFkA%2BUIRX0S9C--ddccHyDVV8%2FZx8UdrJsL6g%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.1247316155.1753301839; Path=/; Domain=github.com; Expires=Thu, 23 Jul 2026 20:17:19 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Thu, 23 Jul 2026 20:17:19 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: EDC6:D3350:1094CF9:13B0F38:6881434F
Share types on objects with getter/setter properties. If the Accessor… · chakra-core/ChakraCore@83f8af8 · GitHub
Copy file name to clipboardExpand all lines: lib/Backend/LowerMDShared.cpp
Copy file name to clipboardExpand all lines: lib/Backend/LowerMDShared.h
Copy file name to clipboardExpand all lines: lib/Backend/ObjTypeSpecFldInfo.cpp
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Commit 83f8af8
committed
Share types on objects with getter/setter properties. If the Accessor bit is set in a property's attributes, that indicates the property is a Getter. The Setter is stored in another slot. Use an array of indices to find the setter associated with a given Getter. Add the option of increasing a TypePath's path length without adding another property ID to its property map. Fix the way we use the accessor inline cache, in both runtime code and jitted code. We need to look at th isOnProto bit to determine which object to get the property from, the object pointed to by the cache (if isOnProto is set) or the current local instance. (This wasn't necessary when objects with accessors didn't share types.) While I was in there, I deleted all the machine-dependent lowering code related to flag caches and added code in Lower.cpp for everyone to share.
1 parent f881870 commit 83f8af8Copy full SHA for 83f8af8
File tree
Expand file treeCollapse file tree
29 files changed
+992
-562
lines changedFilter options
- lib
- Backend
- arm64
- arm
- Common
- Runtime
- Language
- Library
- Types
Expand file treeCollapse file tree
29 files changed
+992
-562
lines changed+207-4Lines changed: 207 additions & 4 deletions
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
430 | 430 |
| |
431 | 431 |
| |
432 | 432 |
| |
433 |
| - | |
| 433 | + | |
434 | 434 |
| |
435 | 435 |
| |
436 | 436 |
| |
| |||
5770 | 5770 |
| |
5771 | 5771 |
| |
5772 | 5772 |
| |
| 5773 | + | |
| 5774 | + | |
| 5775 | + | |
| 5776 | + | |
| 5777 | + | |
| 5778 | + | |
| 5779 | + | |
| 5780 | + | |
| 5781 | + | |
| 5782 | + | |
| 5783 | + | |
| 5784 | + | |
| 5785 | + | |
| 5786 | + | |
| 5787 | + | |
| 5788 | + | |
| 5789 | + | |
| 5790 | + | |
| 5791 | + | |
| 5792 | + | |
| 5793 | + | |
| 5794 | + | |
| 5795 | + | |
| 5796 | + | |
| 5797 | + | |
| 5798 | + | |
| 5799 | + | |
| 5800 | + | |
| 5801 | + | |
| 5802 | + | |
| 5803 | + | |
| 5804 | + | |
| 5805 | + | |
| 5806 | + | |
| 5807 | + | |
| 5808 | + | |
| 5809 | + | |
| 5810 | + | |
| 5811 | + | |
| 5812 | + | |
| 5813 | + | |
| 5814 | + | |
| 5815 | + | |
| 5816 | + | |
| 5817 | + | |
| 5818 | + | |
| 5819 | + | |
| 5820 | + | |
| 5821 | + | |
| 5822 | + | |
| 5823 | + | |
| 5824 | + | |
| 5825 | + | |
| 5826 | + | |
| 5827 | + | |
| 5828 | + | |
| 5829 | + | |
| 5830 | + | |
| 5831 | + | |
| 5832 | + | |
| 5833 | + | |
| 5834 | + | |
| 5835 | + | |
| 5836 | + | |
| 5837 | + | |
| 5838 | + | |
| 5839 | + | |
| 5840 | + | |
| 5841 | + | |
| 5842 | + | |
| 5843 | + | |
| 5844 | + | |
| 5845 | + | |
| 5846 | + | |
| 5847 | + | |
| 5848 | + | |
| 5849 | + | |
| 5850 | + | |
| 5851 | + | |
| 5852 | + | |
| 5853 | + | |
| 5854 | + | |
| 5855 | + | |
| 5856 | + | |
| 5857 | + | |
| 5858 | + | |
| 5859 | + | |
| 5860 | + | |
| 5861 | + | |
| 5862 | + | |
| 5863 | + | |
| 5864 | + | |
| 5865 | + | |
| 5866 | + | |
| 5867 | + | |
| 5868 | + | |
| 5869 | + | |
| 5870 | + | |
| 5871 | + | |
| 5872 | + | |
| 5873 | + | |
| 5874 | + | |
| 5875 | + | |
| 5876 | + | |
| 5877 | + | |
| 5878 | + | |
| 5879 | + | |
| 5880 | + | |
| 5881 | + | |
| 5882 | + | |
| 5883 | + | |
| 5884 | + | |
| 5885 | + | |
| 5886 | + | |
| 5887 | + | |
| 5888 | + | |
| 5889 | + | |
| 5890 | + | |
| 5891 | + | |
| 5892 | + | |
| 5893 | + | |
| 5894 | + | |
| 5895 | + | |
| 5896 | + | |
| 5897 | + | |
| 5898 | + | |
| 5899 | + | |
| 5900 | + | |
| 5901 | + | |
| 5902 | + | |
| 5903 | + | |
| 5904 | + | |
| 5905 | + | |
| 5906 | + | |
| 5907 | + | |
| 5908 | + | |
| 5909 | + | |
| 5910 | + | |
| 5911 | + | |
| 5912 | + | |
| 5913 | + | |
| 5914 | + | |
| 5915 | + | |
| 5916 | + | |
| 5917 | + | |
| 5918 | + | |
| 5919 | + | |
| 5920 | + | |
| 5921 | + | |
| 5922 | + | |
| 5923 | + | |
| 5924 | + | |
| 5925 | + | |
| 5926 | + | |
| 5927 | + | |
| 5928 | + | |
| 5929 | + | |
| 5930 | + | |
| 5931 | + | |
| 5932 | + | |
| 5933 | + | |
| 5934 | + | |
| 5935 | + | |
| 5936 | + | |
| 5937 | + | |
| 5938 | + | |
| 5939 | + | |
| 5940 | + | |
| 5941 | + | |
| 5942 | + | |
| 5943 | + | |
| 5944 | + | |
| 5945 | + | |
| 5946 | + | |
| 5947 | + | |
| 5948 | + | |
| 5949 | + | |
| 5950 | + | |
| 5951 | + | |
| 5952 | + | |
| 5953 | + | |
| 5954 | + | |
| 5955 | + | |
| 5956 | + | |
| 5957 | + | |
| 5958 | + | |
| 5959 | + | |
| 5960 | + | |
| 5961 | + | |
| 5962 | + | |
| 5963 | + | |
| 5964 | + | |
| 5965 | + | |
| 5966 | + | |
| 5967 | + | |
| 5968 | + | |
| 5969 | + | |
| 5970 | + | |
| 5971 | + | |
| 5972 | + | |
| 5973 | + | |
| 5974 | + | |
| 5975 | + | |
5773 | 5976 |
| |
5774 | 5977 |
| |
5775 | 5978 |
| |
| |||
24787 | 24990 |
| |
24788 | 24991 |
| |
24789 | 24992 |
| |
24790 |
| - | |
| 24993 | + | |
24791 | 24994 |
| |
24792 | 24995 |
| |
24793 | 24996 |
| |
| |||
24801 | 25004 |
| |
24802 | 25005 |
| |
24803 | 25006 |
| |
24804 |
| - | |
24805 |
| - | |
| 25007 | + | |
| 25008 | + | |
24806 | 25009 |
| |
24807 | 25010 |
| |
24808 | 25011 |
| |
|
+18-1Lines changed: 18 additions & 1 deletion
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
158 | 158 |
| |
159 | 159 |
| |
160 | 160 |
| |
| 161 | + | |
| 162 | + | |
| 163 | + | |
| 164 | + | |
| 165 | + | |
| 166 | + | |
| 167 | + | |
| 168 | + | |
| 169 | + | |
| 170 | + | |
| 171 | + | |
| 172 | + | |
| 173 | + | |
| 174 | + | |
| 175 | + | |
| 176 | + | |
| 177 | + | |
| 178 | + | |
161 | 179 |
| |
162 | 180 |
| |
163 | 181 |
| |
| |||
614 | 632 |
| |
615 | 633 |
| |
616 | 634 |
| |
617 |
| - | |
618 | 635 |
| |
619 | 636 |
| |
620 | 637 |
| |
|
lib/Backend/LowerMDShared.cpp
Copy file name to clipboardExpand all lines: lib/Backend/LowerMDShared.cpp-78Lines changed: 0 additions & 78 deletions
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
3836 | 3836 |
| |
3837 | 3837 |
| |
3838 | 3838 |
| |
3839 |
| - | |
3840 |
| - | |
3841 |
| - | |
3842 |
| - | |
3843 |
| - | |
3844 |
| - | |
3845 |
| - | |
3846 |
| - | |
3847 |
| - | |
3848 |
| - | |
3849 |
| - | |
3850 |
| - | |
3851 |
| - | |
3852 |
| - | |
3853 |
| - | |
3854 |
| - | |
3855 |
| - | |
3856 |
| - | |
3857 |
| - | |
3858 |
| - | |
3859 |
| - | |
3860 |
| - | |
3861 |
| - | |
3862 |
| - | |
3863 |
| - | |
3864 |
| - | |
3865 |
| - | |
3866 |
| - | |
3867 |
| - | |
3868 |
| - | |
3869 |
| - | |
3870 |
| - | |
3871 |
| - | |
3872 |
| - | |
3873 |
| - | |
3874 |
| - | |
3875 |
| - | |
3876 |
| - | |
3877 |
| - | |
3878 |
| - | |
3879 |
| - | |
3880 |
| - | |
3881 |
| - | |
3882 |
| - | |
3883 |
| - | |
3884 |
| - | |
3885 |
| - | |
3886 |
| - | |
3887 |
| - | |
3888 |
| - | |
3889 |
| - | |
3890 |
| - | |
3891 |
| - | |
3892 |
| - | |
3893 |
| - | |
3894 |
| - | |
3895 |
| - | |
3896 |
| - | |
3897 |
| - | |
3898 |
| - | |
3899 |
| - | |
3900 |
| - | |
3901 |
| - | |
3902 |
| - | |
3903 |
| - | |
3904 |
| - | |
3905 |
| - | |
3906 |
| - | |
3907 |
| - | |
3908 |
| - | |
3909 |
| - | |
3910 |
| - | |
3911 |
| - | |
3912 |
| - | |
3913 |
| - | |
3914 |
| - | |
3915 |
| - | |
3916 |
| - | |
3917 | 3839 |
| |
3918 | 3840 |
| |
3919 | 3841 |
| |
|
lib/Backend/LowerMDShared.h
Copy file name to clipboardExpand all lines: lib/Backend/LowerMDShared.h-1Lines changed: 0 additions & 1 deletion
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
156 | 156 |
| |
157 | 157 |
| |
158 | 158 |
| |
159 |
| - | |
160 | 159 |
| |
161 | 160 |
| |
162 | 161 |
| |
|
lib/Backend/ObjTypeSpecFldInfo.cpp
Copy file name to clipboardExpand all lines: lib/Backend/ObjTypeSpecFldInfo.cpp+6-3Lines changed: 6 additions & 3 deletions
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
300 | 300 |
| |
301 | 301 |
| |
302 | 302 |
| |
303 |
| - | |
| 303 | + | |
304 | 304 |
| |
305 | 305 |
| |
306 | 306 |
| |
| |||
361 | 361 |
| |
362 | 362 |
| |
363 | 363 |
| |
364 |
| - | |
| 364 | + | |
| 365 | + | |
| 366 | + | |
| 367 | + | |
365 | 368 |
| |
366 |
| - | |
| 369 | + | |
367 | 370 |
| |
368 | 371 |
| |
369 | 372 |
| |
|
You can’t perform that action at this time.
0 commit comments