CARVIEW |
Select Language
HTTP/2 200
date: Wed, 23 Jul 2025 06:01:13 GMT
content-type: text/html; charset=utf-8
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-repository-download: git clone https://github.com/chakra-core/ChakraCore.git
etag: W/"653edc0ea41e881f7afef1be1e775573"
cache-control: max-age=0, private, must-revalidate
strict-transport-security: max-age=31536000; includeSubdomains; preload
x-frame-options: deny
x-content-type-options: nosniff
x-xss-protection: 0
referrer-policy: no-referrer-when-downgrade
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=t7oBwGyUm5UcDzgD37JG%2FAJ2YBahMCczmNzM7Jr4RIiuvQACY%2FNHS%2F3kFpWFD7o3YLwgyCmoobbuyCDXrbpuWAjJhTIPSw07Aiih3Mje3NgrMbsKhRBLMeUDB6Lo%2FhwVLyOjlcK%2B2a1UZULNW0%2BacHFKBHAPrtN295xALNKIsC3FDj6lmMkcDn4qcMbrRrJK%2FUoQ%2BLo5bCKKtJnTnOZ308dP9kzJTuZuDNRnFASwO3u176ZtPgi6ZAIcOpXhh%2B0AKMw6A5jqrmIFONt9ZafIIw%3D%3D--wGHxaiJslJ%2BortXF--KzFUHEycr2zLvGDPjIZ42Q%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.1231958083.1753250471; Path=/; Domain=github.com; Expires=Thu, 23 Jul 2026 06:01:11 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Thu, 23 Jul 2026 06:01:11 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: DD6E:20AC8F:49772D:606E3A:68807AA7
Fix incorrect identification of non-local-references when parsing arr… · chakra-core/ChakraCore@1ea9ef6 · GitHub
Copy file name to clipboard
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Commit 1ea9ef6
committed
Fix incorrect identification of non-local-references when parsing arrow function parameter lists. Since we can't identify such syntax on the initial scan and have to backtrack and re-parse, our stacks of identifier references enter an inconsistent state that causes us to bind non-existent references and treat them as closure-captured. This in turn leads to bad byte code generation. The problem is easy to solve in the case of a single arrow function parameter not enclosed in parentheses. To handle the harder case of a list enclosed in parens, advance the current block ID when we begin parsing a parenthetical expression. Identifier references will be created that are amenable to the arrow function case, and if we do wind up with an arrow function, we only need to correct the function ID's on the references we've already made.
1 parent 73f6272 commit 1ea9ef6Copy full SHA for 1ea9ef6
File tree
Expand file treeCollapse file tree
4 files changed
+86
-10
lines changedFilter options
- lib/Parser
- test/es6
Expand file treeCollapse file tree
4 files changed
+86
-10
lines changed+51-10Lines changed: 51 additions & 10 deletions
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
109 | 109 |
| |
110 | 110 |
| |
111 | 111 |
| |
| 112 | + | |
112 | 113 |
| |
113 | 114 |
| |
114 | 115 |
| |
| |||
822 | 823 |
| |
823 | 824 |
| |
824 | 825 |
| |
| 826 | + | |
| 827 | + | |
| 828 | + | |
| 829 | + | |
| 830 | + | |
| 831 | + | |
| 832 | + | |
| 833 | + | |
825 | 834 |
| |
826 | 835 |
| |
827 | 836 |
| |
| |||
2879 | 2888 |
| |
2880 | 2889 |
| |
2881 | 2890 |
| |
2882 |
| - | |
| 2891 | + | |
| 2892 | + | |
| 2893 | + | |
| 2894 | + | |
| 2895 | + | |
| 2896 | + | |
2883 | 2897 |
| |
2884 | 2898 |
| |
2885 | 2899 |
| |
| |||
2910 | 2924 |
| |
2911 | 2925 |
| |
2912 | 2926 |
| |
| 2927 | + | |
2913 | 2928 |
| |
2914 | 2929 |
| |
2915 | 2930 |
| |
| |||
2933 | 2948 |
| |
2934 | 2949 |
| |
2935 | 2950 |
| |
| 2951 | + | |
| 2952 | + | |
| 2953 | + | |
| 2954 | + | |
| 2955 | + | |
| 2956 | + | |
| 2957 | + | |
2936 | 2958 |
| |
2937 | 2959 |
| |
2938 | 2960 |
| |
2939 | 2961 |
| |
2940 | 2962 |
| |
| 2963 | + | |
| 2964 | + | |
| 2965 | + | |
| 2966 | + | |
| 2967 | + | |
| 2968 | + | |
| 2969 | + | |
| 2970 | + | |
| 2971 | + | |
2941 | 2972 |
| |
2942 | 2973 |
| |
2943 | 2974 |
| |
| |||
2949 | 2980 |
| |
2950 | 2981 |
| |
2951 | 2982 |
| |
| 2983 | + | |
2952 | 2984 |
| |
2953 | 2985 |
| |
2954 | 2986 |
| |
| |||
4974 | 5006 |
| |
4975 | 5007 |
| |
4976 | 5008 |
| |
| 5009 | + | |
| 5010 | + | |
| 5011 | + | |
| 5012 | + | |
| 5013 | + | |
4977 | 5014 |
| |
| 5015 | + | |
4978 | 5016 |
| |
4979 | 5017 |
| |
4980 | 5018 |
| |
| |||
5039 | 5077 |
| |
5040 | 5078 |
| |
5041 | 5079 |
| |
5042 |
| - | |
5043 |
| - | |
| 5080 | + | |
| 5081 | + | |
5044 | 5082 |
| |
5045 | 5083 |
| |
5046 | 5084 |
| |
5047 | 5085 |
| |
5048 | 5086 |
| |
5049 |
| - | |
5050 |
| - | |
5051 |
| - | |
5052 |
| - | |
5053 |
| - | |
5054 | 5087 |
| |
5055 | 5088 |
| |
5056 | 5089 |
| |
5057 |
| - | |
| 5090 | + | |
5058 | 5091 |
| |
5059 | 5092 |
| |
5060 | 5093 |
| |
| |||
7962 | 7995 |
| |
7963 | 7996 |
| |
7964 | 7997 |
| |
7965 |
| - | |
| 7998 | + | |
7966 | 7999 |
| |
7967 | 8000 |
| |
7968 | 8001 |
| |
| |||
8530 | 8563 |
| |
8531 | 8564 |
| |
8532 | 8565 |
| |
| 8566 | + | |
| 8567 | + | |
| 8568 | + | |
| 8569 | + | |
| 8570 | + | |
| 8571 | + | |
| 8572 | + | |
| 8573 | + | |
8533 | 8574 |
| |
8534 | 8575 |
| |
8535 | 8576 |
| |
|
+1Lines changed: 1 addition & 0 deletions
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
367 | 367 |
| |
368 | 368 |
| |
369 | 369 |
| |
| 370 | + | |
370 | 371 |
| |
371 | 372 |
| |
372 | 373 |
| |
|
test/es6/lambda-params-shadow.js
Copy file name to clipboard+22Lines changed: 22 additions & 0 deletions
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + |
+12Lines changed: 12 additions & 0 deletions
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
12 | 12 |
| |
13 | 13 |
| |
14 | 14 |
| |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
15 | 27 |
| |
16 | 28 |
| |
17 | 29 |
| |
|
You can’t perform that action at this time.
0 commit comments