fix UT failure; remove unused method

MikeHolman · MikeHolman · commit 1e918e2f73a2 · 2018-03-16T12:12:59.000-07:00
diff --git a/lib/Runtime/Library/JSONStringifier.cpp b/lib/Runtime/Library/JSONStringifier.cpp
@@ -402,6 +402,8 @@ JSONStringifier::AppendObjectElement(
             // If gap is specified, a space is appended
             UInt32Math::Inc(this->totalStringLength);
         }
+
+        jsonObject->Push(*prop);
     }
 }
 
@@ -421,8 +423,6 @@ JSONStringifier::ReadObjectElement(
     this->ReadProperty(propertyName, obj, &prop.propertyValue, value, objectStack);
 
     this->AppendObjectElement(propertyName, jsonObject, &prop);
-
-    jsonObject->Push(prop);
 }
 
 void
@@ -441,8 +441,6 @@ JSONStringifier::ReadObjectElement(
     this->ReadProperty(propertyName, obj, &prop.propertyValue, value, objectStack);
 
     this->AppendObjectElement(propertyName, jsonObject, &prop);
-
-    jsonObject->Push(prop);
 }
 
 // Calculates how many additional characters are needed for printing the Object/Array structure
diff --git a/lib/Runtime/Types/DynamicObjectPropertyEnumerator.h b/lib/Runtime/Types/DynamicObjectPropertyEnumerator.h
@@ -46,7 +46,6 @@ namespace Js
         bool GetSnapShotSemantics() const;
         bool GetUseCache() const;
         ScriptContext * GetScriptContext() const { return scriptContext; }
-        BigPropertyIndex GetInitialPropertyCount() const { return this->initialPropertyCount; }
 
         bool Initialize(DynamicObject * object, EnumeratorFlags flags, ScriptContext * requestContext, ForInCache * forInCache);
         bool IsNullEnumerator() const;
diff --git a/lib/Runtime/Types/JavascriptStaticEnumerator.h b/lib/Runtime/Types/JavascriptStaticEnumerator.h
@@ -39,7 +39,6 @@ namespace Js
         void Reset();
         uint32 GetCurrentItemIndex();
         JavascriptString * MoveAndGetNext(PropertyId& propertyId, PropertyAttributes* attributes = nullptr);
-        BigPropertyIndex GetInitialPropertyCount() const { return this->propertyEnumerator.GetInitialPropertyCount(); }
 
         static uint32 GetOffsetOfCurrentEnumerator() { return offsetof(JavascriptStaticEnumerator, currentEnumerator); }
         static uint32 GetOffsetOfPrefixEnumerator() { return offsetof(JavascriptStaticEnumerator, prefixEnumerator); }

Original file line number	Diff line number	Diff line change
`@@ -402,6 +402,8 @@ JSONStringifier::AppendObjectElement(`
`402`	`402`	`// If gap is specified, a space is appended`
`403`	`403`	`UInt32Math::Inc(this->totalStringLength);`
`404`	`404`	`}`
	`405`	`+`
	`406`	`+ jsonObject->Push(*prop);`
`405`	`407`	`}`
`406`	`408`	`}`
`407`	`409`
`@@ -421,8 +423,6 @@ JSONStringifier::ReadObjectElement(`
`421`	`423`	`this->ReadProperty(propertyName, obj, &prop.propertyValue, value, objectStack);`
`422`	`424`
`423`	`425`	`this->AppendObjectElement(propertyName, jsonObject, &prop);`
`424`		`-`
`425`		`- jsonObject->Push(prop);`
`426`	`426`	`}`
`427`	`427`
`428`	`428`	`void`
`@@ -441,8 +441,6 @@ JSONStringifier::ReadObjectElement(`
`441`	`441`	`this->ReadProperty(propertyName, obj, &prop.propertyValue, value, objectStack);`
`442`	`442`
`443`	`443`	`this->AppendObjectElement(propertyName, jsonObject, &prop);`
`444`		`-`
`445`		`- jsonObject->Push(prop);`
`446`	`444`	`}`
`447`	`445`
`448`	`446`	`// Calculates how many additional characters are needed for printing the Object/Array structure`