[c#] Enable running the C# tests on linux (#1200)

jsturtevant · alexcrichton · web-flow · commit 86e8ae2b8b97 · 2025-03-11T16:55:32.000Z
* Enable running the Csharp tests on linux

Signed-off-by: James Sturtevant &lt;jstur@microsoft.com&gt;

* fix ci

Signed-off-by: James Sturtevant &lt;jstur@microsoft.com&gt;

* We don't have native aot packages for macos avaliable

Signed-off-by: James Sturtevant &lt;jstur@microsoft.com&gt;

* Don't silently pass on macOS

Instead just don't test on macos

* Different github actions syntax

---------

Signed-off-by: James Sturtevant &lt;jstur@microsoft.com&gt;
Co-authored-by: Alex Crichton &lt;alex@alexcrichton.com&gt;
diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml
@@ -60,6 +60,10 @@ jobs:
         os: [ubuntu-latest, macos-latest, windows-latest]
         # moonbit removed from language matrix for now - causing CI failures
         lang: [c, rust, teavm-java, go, csharp]
+        exclude:
+          # For now csharp doesn't work on macos, so exclude it from testing.
+          - os: macos-latest
+            lang: csharp
     runs-on: ${{ matrix.os }}
     steps:
     - uses: actions/checkout@v4
@@ -73,7 +77,7 @@ jobs:
       if: matrix.lang == 'rust'
 
     - uses: ./.github/actions/install-wasi-sdk
-      if: matrix.lang == 'c' || (matrix.lang == 'csharp' && matrix.os == 'windows-latest')
+      if: matrix.lang == 'c' || matrix.lang == 'csharp'
 
     - name: Setup .NET
       uses: actions/setup-dotnet@v4
diff --git a/crates/csharp/src/csproj.rs b/crates/csharp/src/csproj.rs
@@ -91,13 +91,20 @@ impl CSProjectLLVMBuilder {
         );
 
         if self.aot {
+            let os = match std::env::consts::OS {
+                "windows" => "win",
+                "linux" => std::env::consts::OS,
+                other => todo!("OS {} not supported", other),
+            };
+
             csproj.push_str(
-                r#"
+                &format!(
+                    r#"
                 <ItemGroup>
                     <PackageReference Include="Microsoft.DotNet.ILCompiler.LLVM" Version="10.0.0-*" />
-                    <PackageReference Include="runtime.win-x64.Microsoft.DotNet.ILCompiler.LLVM" Version="10.0.0-*" />
+                    <PackageReference Include="runtime.{os}-x64.Microsoft.DotNet.ILCompiler.LLVM" Version="10.0.0-*" />
                 </ItemGroup>
-                "#,
+                "#),
             );
 
             fs::write(
diff --git a/tests/runtime/main.rs b/tests/runtime/main.rs
@@ -659,7 +659,7 @@ fn tests(name: &str, dir_name: &str) -> Result<Vec<PathBuf>> {
     }
 
     #[cfg(feature = "csharp")]
-    if cfg!(windows) && !c_sharp.is_empty() {
+    if !c_sharp.is_empty() {
         let (resolve, world) = resolve_wit_dir(&dir);
         for path in c_sharp.iter() {
             let world_name = &resolve.worlds[world].name;

Original file line number	Diff line number	Diff line change
`@@ -659,7 +659,7 @@ fn tests(name: &str, dir_name: &str) -> Result<Vec<PathBuf>> {`
`659`	`659`	`}`
`660`	`660`
`661`	`661`	`#[cfg(feature = "csharp")]`
`662`		`- if cfg!(windows) && !c_sharp.is_empty() {`
	`662`	`+ if !c_sharp.is_empty() {`
`663`	`663`	`let (resolve, world) = resolve_wit_dir(&dir);`
`664`	`664`	`for path in c_sharp.iter() {`
`665`	`665`	`let world_name = &resolve.worlds[world].name;`