You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on May 25, 2023. It is now read-only.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks for your contribution.
However if a timeout is set globally, this usually means there is a reason why requests should time out after the set time. And if file uploads are to be handled differently, I think it's better to explicitly set this in the fileupload initialization, than to set it globally, which might lead to surprises.
Well, normally someone might set the timeout and just have the response time in mind but for timeout the request time counts as well, in this case the length of the whole upload. In my case it was unexpected and I see no reason why anyone would ever want to have a timeout on an upload request.
there is a reason why requests should time out after the set time
That is a valid argument. I've reconsidered and the surprise of not following the global timeout setting is a lesser concern, so I'll merge it. Thanks for your patience!
Done. Wiki editing is disabled as it was too much of a hassle to revert spam changes.
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A timeout (e.g. set globally to work around certain Google Chrome bugs) would otherwise break file uploads lasting longer than the set value.