You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Apr 11, 2024. It is now read-only.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@D10 / @jdalton When I grabbed that user agent I didn't think IE was emulating firefox, it looks like it is though as the default user agent is: Mozilla/5.0 (Windows NT 6.1; Trident/7.0; rv:11.0) like Gecko
You can close this if you don't want to support it, otherwise I can expand this to support all user agents of IE11 emulating other browsers.
I've added support for detecting IE identifying as other browsers, but not IE masking as other browsers yet. @jdalton do you think we should do that? We could probably just use document.documentMode to find out if the browser is IE, though I'm not sure if other browsers also have document.documentMode.
@D10 Side note -- for our needs that changes you have made (bumping platform.js version and IE commit) are plenty. Not sure what use cases there are for detecting masking, or correct behavior is there.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I got the user agent from a IE11 on windows 7 vm from here: https://www.modern.ie/en-us/virtualization-tools
It was being detected as firefox, this corrects that.