| CARVIEW |
Select Language
HTTP/2 200
date: Fri, 10 Oct 2025 04:00:27 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com github.githubassets.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com wss://alive-staging.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com marketplace-screenshots.githubusercontent.com/ copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=393.084712,conversation_content-fragment;desc="conversation_content fragment";dur=1420.761139,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=308.030284,nginx;desc="NGINX";dur=0.601275,glb;desc="GLB";dur=137.809168
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: 266d7a9
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=c62qJwaOUcshFPsfdVcXvOX563lzlCSRp9wSAUHVF7tqKxT2yYSH1rL%2B0msI2SWCenZRJSpJBzxMmnL%2F%2BsVaOOBKx12Zg%2FrlYi73hguc9abwQL03eb%2FvzRmBAFZ6wJ0BQft%2BFgnvpaOVMZbH3DGtKlBB%2BM8VkSvtUgkhS4w7mki83EWAxB0GwaA7C5y0qaSKqCwrc7Gbsf44pVecvNfH2rVjtAk3n9nD%2BVnqxg7rI3KJr56MJtX6tmHc06KiMquoLK4u9qlK4Rh3RBNoR3nmhw%3D%3D--T%2FIOTjHjJaCGudWv--kK8BowGHA%2BBtmj3rshcDBg%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.1641449600.1760068825; Path=/; Domain=github.com; Expires=Sat, 10 Oct 2026 04:00:25 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Sat, 10 Oct 2026 04:00:25 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: E202:1F3201:1668AB:202E45:68E884D9
Remove Flow support in React preset by ramasilveyra · Pull Request #6118 · babel/babel · GitHub
xtuc
added
area: flow
PR: Breaking Change 💥
A type of pull request used for our changelog categories for next major release
labels
Aug 16, 2017
ramasilveyra
force-pushed
the
remove-flow
branch
2 times, most recently
from
August 19, 2017 20:55
ramasilveyra
force-pushed
the
remove-flow
branch
from
August 19, 2017 21:13
lock
bot
added
the
outdated
A closed issue/PR that is archived due to age. Recommended to make a new issue
label
Oct 6, 2019
Skip to content
Navigation Menu
{{ message }}
-
-
Notifications
You must be signed in to change notification settings - Fork 5.8k
Remove Flow support in React preset #6118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would be ideal but not a good idea to me because too many users are relying on this behavior. |
xtuc
added
area: flow
PR: Breaking Change 💥
|
Why can't we introduce this breaking change in 7.0? |
|
Yes, we could. Let's discuss it at the weekly later today. |
hzoo
approved these changes
Aug 19, 2017
|
Also via https://twitter.com/AdamRackis/status/898568493896839169 and other reports |
existentialism
approved these changes
Aug 19, 2017
| This preset always includes the following plugins: | ||
|
|
||
| - [syntax-jsx](https://babeljs.io/docs/plugins/syntax-jsx/) | ||
| - [transform-flow-strip-types](https://babeljs.io/docs/plugins/transform-flow-strip-types/) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wonder if it's worth including a note about how Flow syntax support is no longer enabled in 7.x?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it's worth it :D . Added this:
> Note: Flow syntax support is no longer enabled in v7. For that, you will need to add the [Flow preset](https://babeljs.io/docs/plugins/preset-flow/).
7db8386 to
e2dee99
Compare
|
The Circle CI build started to fail on the And I cannot reproduce on my side, any ideas? |
ramasilveyra
force-pushed
the
remove-flow
branch
from
e2dee99 to
78e579f
Compare
ramasilveyra
commented
Aug 19, 2017
| throw path.buildCodeFrameError( | ||
| "A @flow directive is required when using Flow annotations with " + | ||
| "babel-preset-react or the `requireDirective` option.", | ||
| "the `requireDirective` option.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also I just found this, I think that it should be changed in this pr too. If i'm wrong please ping me and I will remove this changes.
|
@ramasilveyra I restarted the Circle CI build, now it passes. |
xtuc
approved these changes
Aug 21, 2017
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#6118 (comment) I thought it was against 6.x?
lgtm if it lands in 7 👍
|
@xtuc Was always for 7.0, not planning to do 6.x releases 👍 |
chicoxyzzy
approved these changes
Aug 21, 2017
|
testing in the repl for this build https://babeljs.io/repl/build/4665#?evaluate=false&lineWrap=true&presets=es2015%2Creact%2Cstage-0&babili=false&builtIns=false&debug=false&code_lz=PTAEAECsGcA9QIbQCYDMBQ6BuCBOoBTUAXlAB5kBLLAPjOgAcEA7YO4K2zVAV2YGMALpQD2zRAAoEALlDRBuSswDmASlABvAL5A&experimental=false&loose=false&spec=false&playground=true I guess we need flow/typescript in the repl options now 😄 |
lock
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
area: flow
outdated
A closed issue/PR that is archived due to age. Recommended to make a new issue
PR: Breaking Change 💥
A type of pull request used for our changelog categories for next major release
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
Remove Flow support in React preset. Needed to fix an incompatibility issue with typescript preset, another option could be adding a
noFlowoption.