Add core URI handlers #15935

BinaryMuse · 2017-10-18T23:02:57Z

Atom core should include URI handlers for extremely common tasks, like opening files. This PR implements any such handlers. 💭 s for other useful handlers are welcome.

Open file (with optional line and column numbers) — atom://core/open/file?filename=urlEncodedFileName&line=n&column=n

Todo

Address add atom to possible editors BetterErrors/better_errors#356

Closes #2037

BinaryMuse · 2017-10-19T00:36:53Z

For the /core/open/file handler, it seems like it might be useful to do some URI parsing from the main process in order to call AtomApplication#windowForPaths or something similar to figure out which window we should route the URI event to.

On the other hand, package authors may wish to have access to similar information (that is, meta information about the various open Atom windows), so perhaps we should expose this across the application delegate somehow so it's accessible from renderer process code.

…-core-uri-handlers

BinaryMuse · 2017-10-27T19:29:24Z

This works, although it's not my absolute favorite strategy here. Open to 💭 s from @atom/maintainers if anyone has any :)

UziTech · 2017-10-30T15:40:31Z

I registered the open package to allow a link with the TextMate URL scheme to be open in Atom:

atom://open?url=file:///path/to/file.ext&line=10&column=2

One thing that would be really nice is if Atom could open an entire project that the file is in if it is not already open.

I'm not sure how we would define project, but that is my two cents.

nathansobo · 2017-10-31T18:26:01Z

src/main-process/atom-application.coffee

@@ -67,7 +67,7 @@ class AtomApplication
    {@resourcePath, @devResourcePath, @version, @devMode, @safeMode, @socketPath, @logFile, @userDataDir} = options
    @socketPath = null if options.test or options.benchmark or options.benchmarkTest
    @pidsToOpenWindows = {}
-    @windows = []
+    @windows = new WindowStack()


🎨 Might be nice to rename @windows to @windowStack to help emphasize that it's an object, not an array.

Update references across codebase

Ben3eeE · 2017-11-03T07:27:49Z

👏 🎉

nathansobo · 2017-11-03T12:01:49Z

💥

UziTech · 2017-11-04T05:17:56Z

src/main-process/atom-application.coffee

+      win = new AtomWindow(this, @fileRecoveryService, {resourcePath, windowInitializationScript, devMode, safeMode, windowDimensions, env})
+      @windowStack.addWindow(win)
+      win.on 'window:loaded', ->
+        win.sendURIMessage url


@BinaryMuse Any way we could use HistoryManager to check if url is in a project then load the entire project and open the url?

maybe we would want a setting to open individual files or project if found?

RobinDaugherty · 2017-11-16T21:30:16Z

@BinaryMuse it seems that line number in the URL is treated as a zero-indexed number while all other editors (and the Atom UI) treat this number as one-indexed. So a link to line=56 lands on line 57 in the UI. It seems like it might be best to change this to conform to other editors. Any preference?

BinaryMuse · 2017-11-16T22:18:10Z

@RobinDaugherty Yes, I agree with you. I'll merge a change shortly to fix this. Thanks!

This PR was merged into the 4.1-dev branch. Discussion ---------- [FrameworkBundle] Add atom editor to ide config | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR |  Support for uri handler (added [here](atom/atom#15935)) in Atom editor is still in the current beta version. This works only for windows and mac. Commits ------- 191b837 [FrameworkBundle] Add atom editor to ide config

Michelle Tilley added 2 commits October 18, 2017 16:00

Add core URI handlers

a11efa7

👕

2901a48

Michelle Tilley and others added 4 commits October 19, 2017 14:19

Convert array of windows in AtomApplication to a WindowStack

158622c

Merge branch 'mkt-core-uri-handlers' of github.com:atom/atom into mkt…

9c6a871

…-core-uri-handlers

Run URI handlers in last non-spec window

e1bc9b5

Allow core URI handlers to determine which window to trigger the URI on

8111ba6

BinaryMuse force-pushed the mkt-core-uri-handlers branch from 8e6da3f to 8111ba6 Compare October 19, 2017 22:50

BinaryMuse mentioned this pull request Oct 19, 2017

Add links to open files from stack frames in Atom BinaryMuse/atom-mocha-test-runner#12

Merged

👕

662a397

BinaryMuse mentioned this pull request Oct 19, 2017

Allows atom to open local files by URL scheme #14243

Closed

2 tasks

nathansobo reviewed Oct 31, 2017

View reviewed changes

Michelle Tilley added 10 commits November 1, 2017 14:36

Rename AtomApplication#windows -> #windowStack

2d20886

Update references across codebase

⌨️ fix typo

cbf2d24

Add test for core URI handler window-selection logic

db0fd52

Fix flaky test

668397c

Fix bug in test

ada75ed

✅ update test

178756b

Let's add some debugging

444597c

More debugging

99bef8e

Merge remote-tracking branch 'origin/master' into mkt-core-uri-handlers

fba5fbc

Change the way we test this

0267829

BinaryMuse merged commit a3bb0bb into master Nov 3, 2017

BinaryMuse deleted the mkt-core-uri-handlers branch November 3, 2017 01:40

UziTech reviewed Nov 4, 2017

View reviewed changes

BinaryMuse mentioned this pull request Nov 14, 2017

add atom to possible editors BetterErrors/better_errors#356

Merged

Arcanemagus mentioned this pull request Nov 15, 2017

Make the portal ID a link that opens in Atom atom/teletype#109

Closed

8 tasks

lexcast mentioned this pull request Dec 10, 2017

[FrameworkBundle] Add atom editor to ide config symfony/symfony#25415

Merged

petecoop mentioned this pull request Feb 21, 2018

Add Atom URI Handler filp/whoops#564

Merged

BoykoAlex mentioned this pull request Mar 5, 2018

Atom/Core URL handler support for Markdown inside Datatip #16888

Closed

donquxiote mentioned this pull request Aug 26, 2020

How to Link Editor wiki article is not clear BetterErrors/better_errors#471

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Add core URI handlers #15935

Add core URI handlers #15935

Uh oh!

BinaryMuse commented Oct 18, 2017 •

edited

Loading

Uh oh!

BinaryMuse commented Oct 19, 2017

Uh oh!

BinaryMuse commented Oct 27, 2017

Uh oh!

UziTech commented Oct 30, 2017

Uh oh!

nathansobo Oct 31, 2017

Uh oh!

Ben3eeE commented Nov 3, 2017

Uh oh!

nathansobo commented Nov 3, 2017

Uh oh!

UziTech Nov 4, 2017 •

edited

Loading

Uh oh!

RobinDaugherty commented Nov 16, 2017

Uh oh!

BinaryMuse commented Nov 16, 2017

Uh oh!

Uh oh!

Add core URI handlers #15935

Add core URI handlers #15935

Uh oh!

Conversation

BinaryMuse commented Oct 18, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

BinaryMuse commented Oct 19, 2017

Uh oh!

BinaryMuse commented Oct 27, 2017

Uh oh!

UziTech commented Oct 30, 2017

Uh oh!

nathansobo Oct 31, 2017

Choose a reason for hiding this comment

Uh oh!

Ben3eeE commented Nov 3, 2017

Uh oh!

nathansobo commented Nov 3, 2017

Uh oh!

UziTech Nov 4, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

RobinDaugherty commented Nov 16, 2017

Uh oh!

BinaryMuse commented Nov 16, 2017

Uh oh!

Uh oh!

BinaryMuse commented Oct 18, 2017 •

edited

Loading

UziTech Nov 4, 2017 •

edited

Loading