| CARVIEW |
Select Language
HTTP/2 200
date: Fri, 10 Oct 2025 04:00:39 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com github.githubassets.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com wss://alive-staging.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com marketplace-screenshots.githubusercontent.com/ copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=379.03491,conversation_content-fragment;desc="conversation_content fragment";dur=847.335414,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=255.479491,nginx;desc="NGINX";dur=1.190621,glb;desc="GLB";dur=138.57168
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: 266d7a9
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=NRFJyAPAFdBEB3h%2BP3%2Be090gIXuF6rAtzSmPSbjMUuFxqoPbMS2e%2Bfy246oJSLfGnmUOnZIx9t6YdaMASF1s9uxkoA6g1rCRXV7eBbq2SRf2lZQHLDQ1TbiSOsqoBBJ2wd%2F9tkAcMMMQ%2BPBCCIY1j%2Bk4YEBPjbi1d33OtLn%2FKnUTof1b9%2BM6NXizRe1wkmcik8VaIV2fLHWs7dd7sMe0yQjIUIifv5ByGJeogIAJpRBMDd%2Fgl9PSqfGhkUsVw5ILv7wcg1ofUS2%2Fn8DwNSfksA%3D%3D--pxUAErLddmScZT8u--20%2BGXiBzm%2FpdckFRmY1o1g%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.385867305.1760068838; Path=/; Domain=github.com; Expires=Sat, 10 Oct 2026 04:00:38 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Sat, 10 Oct 2026 04:00:38 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: B5E2:2AA7F:122760D:161AC92:68E884E6
Adds a tslint rule for unmocking when doing tests with tracking by orta · Pull Request #1174 · artsy/reaction · GitHub
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 75
Adds a tslint rule for unmocking when doing tests with tracking #1174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orta
commented
Aug 23, 2018
| } | ||
| } | ||
|
|
||
| module.exports = { Rule: Rule } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This has to be a .js file, so this gives you most of the typing ( // @ts-check and the jsdoc ) but none of the ts compilation overhead.
|
Deploy preview for artsy-reaction ready! Built with commit 03d2e2d |
alloy
reviewed
Aug 23, 2018
| "You need to un-mock react-tracking if you are using mockTracking in this file." | ||
| const fix = new Lint.Fix("fix-tracking", [ | ||
| new Lint.Replacement(0, 0, `jest.unmock("react-tracking")\n`), | ||
| ]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice 👌
alloy
reviewed
Aug 23, 2018
| // Does it include mockTracking but not un-mock react-tracking? | ||
| if ( | ||
| sourceFile.text.includes("mockTracking") && | ||
| !sourceFile.text.includes(`jest.unmock("react-tracking")`) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I’m pretty sure people at Artsy write single quotes because of ergonomics and let prettier handle the rewriting to use double quotes, meaning that this won’t catch that until after saving/prettifying. I don’t think it’ll be an actual issue, but it does mean it will take at least one save before they get to see this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can live with this, aye
alloy
approved these changes
Aug 23, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great stuff, both for the specific rule and the hoot example being set 👏
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
None yet
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
We've talked about doing these before, but me and @ansor4 wasted a bunch of time on something we can easily make a linter rule for - so this fixes #1172 and now we have at least one custom lint rule, so the next ones are much easier to write.
Making the rules is simple, and I added docs so it's easy for the next person.
🎉