OK, this is feeling like it can only really get done with some pair programming, @jorystiefel want to do some with me tomorrow?

@orta thought you'd never ask

one more test, and then some on-device testing needing.

Groovy!

This should probably green now. I will do some on-device testing.

And more rebasing

Maybe I missed it, but it appears that you are not stopping webview loading when the view disappears, which is what TSMiniBrowser used to do. With many of our web pages being resource heavy, it kinda makes sense to save the user’s bandwidth once they navigate away to another page.

This is also what the loaded ivar was for, so that the webview could be reloaded if it never finished loading the first time around and the user navigates back to the webview.

Intens change, I love it, finally gone with the ugly chrome and way better progress hooks! 👏

TODO

• url - URL
• self.view.window
• status codes
• navigationAction.navigationType == WKNavigationTypeOther
• self.webView evaluateJavaScript

I've updated the PR - I've also removed the web view admin stuff. If I really care ,I'll go in and add something like https://github.com/Naituw/WBWebViewConsole

force pushed changes requested this morning

@orta There’s still a bunch of CI errors about shouldLoadNavigationAction:, what gives?

laziness, didn't run tests after my changes, will fix after swift at artsy

Groovy, baby!

alright, all good again

Sweet! 👯