You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I've removed one test because it is inconsistent with the use of the view controller. It was testing what happened when a user changes a setting (it enables the clear/apply buttons), but I can't think of a way to simulate user interaction in a realistic way so the test is actually useful.
The reason will be displayed to describe this comment to others. Learn more.
π¬ I forgot that I could do that.
I can change to that, honestly I kind of like this because it centralizes the priorities in an enum, but we could find a middle ground. Or whatever, I don't feel strongly.
The reason will be displayed to describe this comment to others. Learn more.
me neither for now, happy to let this settle out over some time, but it's a global UIView technique that's unique to just this view controller, it should be everywhere or nowhere
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #971.
On iPhone:
And iPad, shown working: