You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Apr 12, 2024. It is now read-only.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Addresses:
- A TODO where most routes was being compiled and processed every single route change. Routes are now processed up front and simply matched
- Routes are now processed in the order in which they are added instead of arbitrarily.
- Helps with #1147
- Helps with #1159
- Makes #918 easier
- It is now possible to match the forwardslash character.
- It is now possible to restrict your match to string, int or path.
@xealot thnx for your contribution! This PR will require some more work before it can be merged. In particular, could you go over the https://docs.angularjs.org/misc/contribute and make sure that:
documentation is updated
CLA signed
commit message follow the guidelines - you should also squash 2 commits into one.
@pkozlowski-opensource: No, we are not. This PR covers the functionality of #1147 which ultimately got reworked by me into #1560.
I said that the PR is cool because it enhances the route specification by allowing restricting params to int, string and path values.
But, as you said before, the PR must be reworked in order to being taken into consideration. This means rebasing, including documentation and rewriting the commit message.
@pkozlowski-opensource CLA is signed, I must have fat fingered #1159, because that doesn't seem relevant at all. I believe there is another routing/matching open somewhere that this addresses fully or in part.
I will attempt to correct the lack of documentation and squish the commits.
@lrlopez thanks, the tests are a decent source to see how it works. I will try to put the documentation in the source. Also if you look at the way werkzeug does routing this mirrors that strategy.
PR is stale. Can not be merged to master (needs to be rebase) Master already has similar feature (*path) wich makes this PR less useful. For this reason, I am closing it, feel free to reopen once fixed up.
This, however, is much more flexible than the catch-all
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
None yet
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
General routing improvements to support slash matching, ordered routing of ambiguous urls, typed groups and likely performance improvements.
Angular now basically supports the werkzeug routing syntax.
/foo/:bar
/foo/<path:bar>
/foo/<string:bar>/
/foot/<path:bar>/:id/
Addresses: