CARVIEW |
Select Language
HTTP/2 200
date: Mon, 13 Oct 2025 03:22:44 GMT
content-type: text/html; charset=utf-8
cache-control: no-cache
content-security-policy: default-src 'none'; base-uri 'self'; child-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/; connect-src 'self' uploads.github.com www.githubstatus.com collector.github.com raw.githubusercontent.com api.github.com github-cloud.s3.amazonaws.com github-production-repository-file-5c1aeb.s3.amazonaws.com github-production-upload-manifest-file-7fdce7.s3.amazonaws.com github-production-user-asset-6210df.s3.amazonaws.com *.rel.tunnels.api.visualstudio.com wss://*.rel.tunnels.api.visualstudio.com github.githubassets.com objects-origin.githubusercontent.com copilot-proxy.githubusercontent.com proxy.individual.githubcopilot.com proxy.business.githubcopilot.com proxy.enterprise.githubcopilot.com *.actions.githubusercontent.com wss://*.actions.githubusercontent.com productionresultssa0.blob.core.windows.net/ productionresultssa1.blob.core.windows.net/ productionresultssa2.blob.core.windows.net/ productionresultssa3.blob.core.windows.net/ productionresultssa4.blob.core.windows.net/ productionresultssa5.blob.core.windows.net/ productionresultssa6.blob.core.windows.net/ productionresultssa7.blob.core.windows.net/ productionresultssa8.blob.core.windows.net/ productionresultssa9.blob.core.windows.net/ productionresultssa10.blob.core.windows.net/ productionresultssa11.blob.core.windows.net/ productionresultssa12.blob.core.windows.net/ productionresultssa13.blob.core.windows.net/ productionresultssa14.blob.core.windows.net/ productionresultssa15.blob.core.windows.net/ productionresultssa16.blob.core.windows.net/ productionresultssa17.blob.core.windows.net/ productionresultssa18.blob.core.windows.net/ productionresultssa19.blob.core.windows.net/ github-production-repository-image-32fea6.s3.amazonaws.com github-production-release-asset-2e65be.s3.amazonaws.com insights.github.com wss://alive.github.com wss://alive-staging.github.com api.githubcopilot.com api.individual.githubcopilot.com api.business.githubcopilot.com api.enterprise.githubcopilot.com; font-src github.githubassets.com; form-action 'self' github.com gist.github.com copilot-workspace.githubnext.com objects-origin.githubusercontent.com; frame-ancestors 'none'; frame-src viewscreen.githubusercontent.com notebooks.githubusercontent.com; img-src 'self' data: blob: github.githubassets.com media.githubusercontent.com camo.githubusercontent.com identicons.github.com avatars.githubusercontent.com private-avatars.githubusercontent.com github-cloud.s3.amazonaws.com objects.githubusercontent.com release-assets.githubusercontent.com secured-user-images.githubusercontent.com/ user-images.githubusercontent.com/ private-user-images.githubusercontent.com opengraph.githubassets.com marketplace-screenshots.githubusercontent.com/ copilotprodattachments.blob.core.windows.net/github-production-copilot-attachments/ github-production-user-asset-6210df.s3.amazonaws.com customer-stories-feed.github.com spotlights-feed.github.com objects-origin.githubusercontent.com *.githubusercontent.com; manifest-src 'self'; media-src github.com user-images.githubusercontent.com/ secured-user-images.githubusercontent.com/ private-user-images.githubusercontent.com github-production-user-asset-6210df.s3.amazonaws.com gist.github.com; script-src github.githubassets.com; style-src 'unsafe-inline' github.githubassets.com; upgrade-insecure-requests; worker-src github.githubassets.com github.com/assets-cdn/worker/ github.com/assets/ gist.github.com/assets-cdn/worker/
referrer-policy: no-referrer-when-downgrade
server-timing: pull_request_layout-fragment;desc="pull_request_layout fragment";dur=389.422017,conversation_content-fragment;desc="conversation_content fragment";dur=396.770918,conversation_sidebar-fragment;desc="conversation_sidebar fragment";dur=249.726146,nginx;desc="NGINX";dur=1.012359,glb;desc="GLB";dur=140.322339
strict-transport-security: max-age=31536000; includeSubdomains; preload
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, X-Requested-With,Accept-Encoding, Accept, X-Requested-With
x-content-type-options: nosniff
x-frame-options: deny
x-voltron-version: aab62e3
x-xss-protection: 0
server: github.com
content-encoding: gzip
accept-ranges: bytes
set-cookie: _gh_sess=goUjcOzjV55rymoGorTZ3xaUC6MiUEbUUu6pt%2FDEFYnwD0fzkEsvo1VfiIM6NY0BWkzMBPblux%2BQVJaLHWIxFJEuwdPdXznw2uPXesXV9unbgeAQwlYYh%2FSpwSf3mIZ14PWCaHMC%2FAecVL%2FtWi8gORM5f50GxVTE1fEQAUylEjoF%2BlVMe1kQta0KVY2Uu2tIuRnIXpqMggYoMvsnIoasrl2MR4JT6Ekok7yXf4Hg5MQkfXT%2BXt2Pm%2FznUfHSe5DfWy2YEVjGfeq%2BTJJk1ABHrA%3D%3D--OsfzgJV%2Bj%2BYX1f6P--3Fd9HAY56Ip5ozgdcNeqYw%3D%3D; Path=/; HttpOnly; Secure; SameSite=Lax
set-cookie: _octo=GH1.1.552141637.1760325764; Path=/; Domain=github.com; Expires=Tue, 13 Oct 2026 03:22:44 GMT; Secure; SameSite=Lax
set-cookie: logged_in=no; Path=/; Domain=github.com; Expires=Tue, 13 Oct 2026 03:22:44 GMT; HttpOnly; Secure; SameSite=Lax
x-github-request-id: 9F40:8729A:1251592:184146A:68EC7084
Fix NPE in MediaControllerImplLegacy#connectToSession() by h6ah4i Β· Pull Request #59 Β· androidx/media Β· GitHub
Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 628
Fix NPE in MediaControllerImplLegacy#connectToSession() #59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
icbaker
merged 2 commits into
androidx:main
from
h6ah4i:fix/cleanup-callbacks-on-media-controller-release
Apr 26, 2022
Merged
Fix NPE in MediaControllerImplLegacy#connectToSession() #59
icbaker
merged 2 commits into
androidx:main
from
h6ah4i:fix/cleanup-callbacks-on-media-controller-release
Apr 26, 2022
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current implementation of the release() method have a bug; it does not clear pending messages/callbacks queued to the applicationHandler.
This fixes the NPE ocuured in the MediaControllerImplLegacy#connectToSession() right after MediaController#release() is called.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You canβt perform that action at this time.
This pull request fixes a
NullPointerException
occurs inside of theMediaControllerImplLegacy#connectToSession()
.Where the
NPE
occursmedia/libraries/session/src/main/java/androidx/media3/session/MediaControllerImplLegacy.java
Line 1274 in 72a4fb0
Scenario
MediaController
instanceMediaControllerImplLegacy
posts a callback which is executed on the main threadMediaController#release()
immediately on the main threadMediaControllerImplLegacy
setscontrollerCompat = null
controllerCompat.isSessionReady()
is called π₯